Upgrade glimmer-vm dependencies to 0.38.1

[WenInCode]

What's in this PR?

Upgrades the glimmer-vm dependencies to 0.38.1.

I put this together as step 1 of 2 for #17492

Things to note

in doing so I ran into the following error:

➜  ember.js git:(master) ✗ yarn build
yarn run v1.13.0
$ ember build --environment production
Could not start watchman
Visit https://ember-cli.com/user-guide/#watchman for more info.
Environment: production

<--- Last few GCs --->

[73311:0x103800000]    24609 ms: Scavenge 1390.2 (1422.1) -> 1389.9 (1423.1) MB, 3.5 / 0.0 ms  (average mu = 0.101, current mu = 0.021) allocation failure
[73311:0x103800000]    25528 ms: Mark-sweep 1390.6 (1423.1) -> 1390.2 (1422.6) MB, 917.0 / 0.0 ms  (average mu = 0.057, current mu = 0.009) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x264ea675be3d]
    1: StubFrame [pc: 0x264ea675d3c6]
Security context: 0x3da1efb9e6e1 <JSObject>
    2: getIntersectionType(aka getIntersectionType) [0x3da12a2941a1] [/Users/tylerwendlandt/Development/OSS/ember.js/node_modules/typescript/lib/typescript.js:~37286] [pc=0x264ea6dbdda2](this=0x3da1897826f1 <undefined>,types=0x3da1ef23a359 <JSArray[4]>,aliasSymbol=0x3da1897826f1 <undefined>,aliasTypeArguments=0x3da189782...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x10003b125 node::Abort() [/Users/tylerwendlandt/.nvm/versions/node/v10.15.0/bin/node]
 2: 0x10003b32f node::OnFatalError(char const*, char const*) [/Users/tylerwendlandt/.nvm/versions/node/v10.15.0/bin/node]
 3: 0x1001a8e85 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/Users/tylerwendlandt/.nvm/versions/node/v10.15.0/bin/node]
 4: 0x1005742a2 v8::internal::Heap::FatalProcessOutOfMemory(char const*) [/Users/tylerwendlandt/.nvm/versions/node/v10.15.0/bin/node]
 5: 0x100576d75 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [/Users/tylerwendlandt/.nvm/versions/node/v10.15.0/bin/node]
 6: 0x100572c1f v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/Users/tylerwendlandt/.nvm/versions/node/v10.15.0/bin/node]
 7: 0x100570df4 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/Users/tylerwendlandt/.nvm/versions/node/v10.15.0/bin/node]
 8: 0x10057d68c v8::internal::Heap::AllocateRawWithLigthRetry(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [/Users/tylerwendlandt/.nvm/versions/node/v10.15.0/bin/node]
 9: 0x10057d70f v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [/Users/tylerwendlandt/.nvm/versions/node/v10.15.0/bin/node]
10: 0x10054d054 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [/Users/tylerwendlandt/.nvm/versions/node/v10.15.0/bin/node]
11: 0x1007d4f24 v8::internal::Runtime_AllocateInNewSpace(int, v8::internal::Object**, v8::internal::Isolate*) [/Users/tylerwendlandt/.nvm/versions/node/v10.15.0/bin/node]
12: 0x264ea675be3d
error Command failed with signal "SIGABRT".

I believe this is may be related to upgrading broccoli-typescript-compiler. So I upgraded it in this repo as well. That seemed to have resolved the issue.

Also, as of [email protected] isSerializationFirstNode has been moved to @glimmer/runtime so I updated the import.

References

• changes in glimmer-vm 0.37.1 -> 0.38.1
• Replace valueForCapturedArguments with CapturedAruments#value #17492

[WenInCode]

I'm not exactly sure what I should be making of some of these linting errors that are coming through.

For example:

packages/@ember/-internals/glimmer/lib/helpers/loc.ts:41:26 - error TS2345: Argument of type 'Opaque[]' is not assignable to parameter of type '[string, any[]]'.
  Type 'Opaque[]' is missing the following properties from type '[string, any[]]': 0, 1

41   return loc.apply(null, params);

I see that the loc function is in fact expecting a string and a formats array of type any[]. Should I be destructuring the params into a string and formats to pass to the loc function? I am also curious what caused these linting errors to be introduced? The upgrade to broccoli-typescript-compiler?

Thanks :)