Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace valueForCapturedArguments with CapturedAruments#value #17492

Closed
rwjblue opened this issue Jan 18, 2019 · 4 comments
Closed

Replace valueForCapturedArguments with CapturedAruments#value #17492

rwjblue opened this issue Jan 18, 2019 · 4 comments

Comments

@rwjblue
Copy link
Member

rwjblue commented Jan 18, 2019

export function valueForCapturedArgs(args: CapturedArguments): ManagerArgs {
return {
named: args.named.value(),
positional: args.positional.value(),
};
}

should be replaced with usage of the new CapturedArguments.prototype.value method added in glimmerjs/glimmer-vm#832. This will require updating to a glimmer-vm version after 0.38.0.

@eplata31
Copy link

Hello, do you still need help with this?

@eplata31
Copy link

I think this issue is solved by commit [FEATURE ember-glimmer-angle-bracket-built-ins] and refactor #17788. If so please let me know and it might be good to close the issue.

@rwjblue
Copy link
Member Author

rwjblue commented Apr 23, 2019

Awesome, thank you for tracking that down!

@rwjblue rwjblue closed this as completed Apr 23, 2019
@eplata31
Copy link

Glad to help 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants