cleanup _lookupPartial
#16793
Merged
cleanup _lookupPartial
#16793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bekzod
commented
Jul 5, 2018
| } else { | ||
| throw new Error(`${name} is not a partial`); | ||
| } | ||
| } | ||
|
|
||
| private _lookupModifier(name: string) { | ||
| let modifier = this.builtInModifiers[name]; | ||
| if (modifier !== undefined) { |
There was a problem hiding this comment.
there is already undefined check downstream in handle method, so this looks unnecessary
rwjblue
requested changes
Jul 9, 2018
| this.name = name; | ||
| this.namespace = undefined; | ||
| } else { | ||
| if (namespaceDelimiterOffset !== -1) { |
There was a problem hiding this comment.
This seems unrelated to the other changes in the PR to me, can you split it out into a separate PR?
bekzod
force-pushed
the
cleanup-lookup-partial
branch
from
ef6db1b
to
531be15
Compare
|
done |
krisselden
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.