cleanup _lookupPartial

emberjs · Jul 5, 2018 · ef6db1b · ef6db1b
1 parent 64fe277
commit ef6db1b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/packages/ember-glimmer/lib/resolver.ts b/packages/ember-glimmer/lib/resolver.ts
@@ -262,21 +262,16 @@ export default class RuntimeResolver implements IRuntimeResolver<OwnedTemplateMe
 
   private _lookupPartial(name: string, meta: OwnedTemplateMeta): PartialDefinition {
     const template = lookupPartial(name, meta.owner);
-    const partial = new PartialDefinition(name, lookupPartial(name, meta.owner));
 
     if (template) {
-      return partial;
+      return new PartialDefinition(name, template);
     } else {
       throw new Error(`${name} is not a partial`);
     }
   }
 
   private _lookupModifier(name: string) {
-    let modifier = this.builtInModifiers[name];
-    if (modifier !== undefined) {
-      return modifier;
-    }
-    return null;
+    return this.builtInModifiers[name];
   }
 
   private _parseNameForNamespace(_name: string) {

diff --git a/packages/ember-metal/lib/injected_property.ts b/packages/ember-metal/lib/injected_property.ts
@@ -42,10 +42,7 @@ export default class InjectedProperty extends ComputedProperty {
 
       if (name) {
         let namespaceDelimiterOffset = name.indexOf('::');
-        if (namespaceDelimiterOffset === -1) {
-          this.name = name;
-          this.namespace = undefined;
-        } else {
+        if (namespaceDelimiterOffset !== -1) {
           this.name = name.slice(namespaceDelimiterOffset + 2);
           this.namespace = name.slice(0, namespaceDelimiterOffset);
         }