Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix curly component class reference setup #16572

Merged
merged 2 commits into from
Apr 22, 2018
Merged

Fix curly component class reference setup #16572

merged 2 commits into from
Apr 22, 2018

Commits on Apr 22, 2018

  1. failing tests for #16505

    @ef4
    ef4 committed Apr 22, 2018
    Configuration menu
    Copy the full SHA
    6943f8e View commit details
    Browse the repository at this point in the history

  2. fix 16505: construct valid curly component manager class ref 

    This fixes 16505. The curly component manager was looking at the current value of its class argument reference during creation, which is never the right thing to do -- the references need to be agnostic to value because value is going to change through the lifetime of the component.

I'm using `SimpleClassNameBindingReference` here instead of `ClassNameBinding.install` because `ClassNameBinding.install` brings along more microsyntax, and AFAIK we don't support the `classNameBindings` microsyntax in template-inline class arguments like `{{some-component class=something}}`.
    @ef4
    ef4 committed Apr 22, 2018
    Configuration menu
    Copy the full SHA
    67721fd View commit details
    Browse the repository at this point in the history