Fix curly component class reference setup #16572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes 16505. The curly component manager was looking at the current value of its class argument reference during creation, which is never the right thing to do -- the references need to be agnostic to value because value is going to change through the lifetime of the component.
I'm using `SimpleClassNameBindingReference` here instead of `ClassNameBinding.install` because `ClassNameBinding.install` brings along more microsyntax, and AFAIK we don't support the `classNameBindings` microsyntax in template-inline class arguments like `{{some-component class=something}}`.
rwjblue
approved these changes
Apr 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #16505 . The curly component manager was looking at the current value of its class argument reference during creation, which is never the right thing to do -- the references need to be agnostic to value because value is going to change through the lifetime of the component.
I'm using
SimpleClassNameBindingReferencehere instead ofClassNameBinding.installbecauseClassNameBinding.installbrings along more microsyntax, and AFAIK we don't support theclassNameBindingsmicrosyntax in template-inline class arguments like{{some-component class=something}}.