[BUGFIX release] Ensure proxies have access to getOwner(this).
#16493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, when in debug builds, any "proxy" (i.e. something with `unknownProperty`) would _not_ have access to an `owner` object via `getOwner(this)`. This is because of our association with the `FACTORY_FOR` weakmap is only setup for the actual `CoreObject` instance being created, but when `unknownProperty` exists we never expose the "real" `CoreObject` instance and instead expose a native JS `Proxy` (so that we can trap usage of `instance.foo` and properly error). This fix ensures that the native proxy that is returned is also associated with the factory, and can properly access `getOwner(this)` / `._debugContainerKey` / etc.
|
I've pulled these changes into the beta and release branches, you should be able to use the latest release / beta builds once CI is completed and the changes should be included in the next release of each branch... |
|
Hi @rwjblue ! Thanks was the quick fix 😄
I'm unable to find the latest |
|
@niranjan94 I had the same question yesterday, the answer can be found here |
|
Thanks a lot @Dhaulagiri ! That works. |
niranjan94
added a commit
to fossasia/open-event-frontend
that referenced
this pull request
Apr 16, 2018
Using a direct link to ember-source release until emberjs/ember.js#16493 gets tagged into an npm release
niranjan94
added a commit
to fossasia/open-event-frontend
that referenced
this pull request
Apr 17, 2018
Using a direct link to ember-source release until emberjs/ember.js#16493 gets tagged into an npm release
SaptakS
pushed a commit
to fossasia/open-event-frontend
that referenced
this pull request
May 29, 2018
Using a direct link to ember-source release until emberjs/ember.js#16493 gets tagged into an npm release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when in debug builds, any "proxy" (i.e. something with
unknownProperty) would not have access to anownerobject viagetOwner(this). This is because of our association with theFACTORY_FORweakmap is only setup for the actualCoreObjectinstance being created, but whenunknownPropertyexists we never expose the "real"CoreObjectinstance and instead expose a native JSProxy(so that we can trap usage ofinstance.fooand properly error).This fix ensures that the native proxy that is returned is also associated with the factory, and can properly access
getOwner(this)/._debugContainerKey/ etc.Fixes #16484