Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.1.0] getOwner returning false in ObjectProxy.init #16484

Closed
lucacorti opened this issue Apr 11, 2018 · 5 comments · Fixed by #16493
Closed

[3.1.0] getOwner returning false in ObjectProxy.init #16484

lucacorti opened this issue Apr 11, 2018 · 5 comments · Fixed by #16493

Comments

@lucacorti
Copy link

getOwner(this) in ObjectProxy.init was returning the container in 3.0. Since 3.1 it returns false.
this looks quite different:

3.0:
screen shot 2018-04-11 at 16 33 57

3.1:
screen shot 2018-04-11 at 16 41 28
@gmurphey gmurphey mentioned this issue Apr 11, 2018
Closed
@rwjblue
Copy link
Member

rwjblue commented Apr 11, 2018

@lucacorti - Thanks for reporting! Definitely a bug...

@rwjblue
Copy link
Member

rwjblue commented Apr 11, 2018

This is related to #16148...

@rwjblue
Copy link
Member

rwjblue commented Apr 11, 2018

@lucacorti - Can you share a code snippet showing how the object proxy is being created?

@gmurphey
Copy link

@rwjblue the issue was originally created for this service:

https://github.com/gmurphey/ember-config-service/blob/master/addon/services/config.js

@rwjblue rwjblue mentioned this issue Apr 11, 2018
Merged
@rwjblue
Copy link
Member

rwjblue commented Apr 11, 2018

Will be fixed by #16493...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX release] Ensure proxies have access to getOwner(this). rwjblue/ember.js
3 participants
@rwjblue @gmurphey @lucacorti