Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] Allow usage of bound properties in {{link-to}}. #12456

Merged
merged 2 commits into from
Oct 8, 2015
Merged

[BUGFIX beta] Allow usage of bound properties in {{link-to}}. #12456

merged 2 commits into from
Oct 8, 2015

Commits on Oct 7, 2015

  1. [BUGFIX release] Avoid this.attrs.params in LinkComponent. 

    Due to the nature of `positionalParams`, it is trivial to supply
`params` as a hash argument to `{{link-to}}` instead of ordered args
(this allows truly dynamic link's). However, if `{{link-to params=foo}}`
is used `params` will be a `MutableCell` and the current code throws an
error in that circumstance.

*tldr;* `this.attrs` should be avoided. It is quite a 🧌 in
non-`GlimmerComponent`'s.
    @rwjblue
    rwjblue committed Oct 7, 2015
    Configuration menu
    Copy the full SHA
    8f8f154 View commit details
    Browse the repository at this point in the history

  2. [BUGFIX beta] Allow usage of bound properties in {{link-to}}. 

    Due to values in `this.attrs` being either a `MutableCell` or the actual
value, many flags in `link-to` would not function properly when provided
a bound property.
    @rwjblue
    rwjblue committed Oct 7, 2015
    Configuration menu
    Copy the full SHA
    036bf4e View commit details
    Browse the repository at this point in the history