[BUGFIX beta] Allow usage of bound properties in {{link-to}}. #12456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the nature of `positionalParams`, it is trivial to supply
`params` as a hash argument to `{{link-to}}` instead of ordered args
(this allows truly dynamic link's). However, if `{{link-to params=foo}}`
is used `params` will be a `MutableCell` and the current code throws an
error in that circumstance.
*tldr;* `this.attrs` should be avoided. It is quite a 🧌 in
non-`GlimmerComponent`'s.
Due to values in `this.attrs` being either a `MutableCell` or the actual value, many flags in `link-to` would not function properly when provided a bound property.
rwjblue
added a commit
that referenced
this pull request
Oct 8, 2015
[BUGFIX beta] Allow usage of bound properties in {{link-to}}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to values in
this.attrsbeing either aMutableCellor the actual value, many flags inlink-towould not function properly when provided abound property. This PR fixes that by using the standard public API for accessing a components provided attributes (
this.get('attributeName')).tldr;
in non-
this.attrsshould be avoided. It is quite aGlimmerComponent's.Note: This builds on top of #12454, but due to this being a larger set of changes I preferred to make this a separate PR that is targetted to 2.2 beta.