Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] Prevent classNames from being duplicated. #12184

Merged
merged 2 commits into from
Aug 23, 2015
Merged

[BUGFIX beta] Prevent classNames from being duplicated. #12184

merged 2 commits into from
Aug 23, 2015

Commits on Aug 23, 2015

  1. Add a failing test that checks if classNames in DOM reflect the compo… 

    …nents classNames

(cherry picked from commit 4d587dd)
    @fpauser @rwjblue
    fpauser authored and rwjblue committed Aug 23, 2015
    Configuration menu
    Copy the full SHA
    e38bd8f View commit details
    Browse the repository at this point in the history

  2. [BUGFIX beta] Prevent classNames from being duplicated. 

    When a component is created we pass all `attrs` as root properties. In
this case, that means that the `classNames` concatenated properties have
already been merged/handled.

The fix is to remove the processing of `attrs.classNames` from
`normalizeClass`, which prevents any classes provided via `classNames`
from being added twice.
    @rwjblue
    rwjblue committed Aug 23, 2015
    Configuration menu
    Copy the full SHA
    03a29b9 View commit details
    Browse the repository at this point in the history