[BUGFIX beta] Prevent classNames from being duplicated.
#12184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nents classNames (cherry picked from commit 4d587dd)
When a component is created we pass all `attrs` as root properties. In this case, that means that the `classNames` concatenated properties have already been merged/handled. The fix is to remove the processing of `attrs.classNames` from `normalizeClass`, which prevents any classes provided via `classNames` from being added twice.
rwjblue
added a commit
that referenced
this pull request
Aug 23, 2015
[BUGFIX beta] Prevent `classNames` from being duplicated.
|
@rwjblue it doesn't look like this fix is included in 1.13 (see this twiddle for reproduction). Any opposition to a PR into the 1.13 branch with this change? |
|
@Dhaulagiri - Correct, this PR was targeted at |
|
At this point it is more confusing to see than an actual problem. It'll only take a couple of minutes to cherry pick these commits, so I'll probably do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a component is created we pass all
attrsas root properties. In this case, that means that theclassNamesconcatenated properties have already been merged/handled.The fix is to remove the processing of
attrs.classNamesfromnormalizeClass, which prevents any classes provided viaclassNamesfrom being added twice.Closes #11609.
Fixes #11600.
Fixed #12146.