Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] {{get}} helper subscribes to values and can be updated #11691

Merged
merged 1 commit into from
Jul 16, 2015
Merged

[BUGFIX beta] {{get}} helper subscribes to values and can be updated #11691

merged 1 commit into from
Jul 16, 2015

Commits on Jul 16, 2015

  1. [BUGFIX beta] {{get}} helper subscribes to values and can be updated 

    This commit fixes two issues:

1. When using the {{get}} helper it sometimes wouldn't update correctly.

Because a helper and a keyword are being used, ember is invoking the helper logic and wrapping the stream the get keyword creates in a BuiltInHelperStream - it also would not subscribe the morph to the stream. This subscription is where the error lies.

To fix this the helper has been removed and only keyword logic is implemented.

2. It was previously not possible to use the {{input}} helper with the {{get}} helper - this functionality has now been added using the mut keyword, e.g:

{{input value=(mut (get source path)) type='text'}}
    @jmurphyau
    jmurphyau committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    de5446f View commit details
    Browse the repository at this point in the history