[BUGFIX beta] {{get}} helper subscribes to values and can be updated #11691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| view = EmberView.create({ | ||
| context: context, | ||
| container: container, | ||
| template: compile('{{input id=\'get-input\' type=\'text\' value=(mut (get source \'banana\'))}}') |
There was a problem hiding this comment.
Can you use back ticks instead of single quotes?
`{{input id='get-input' ...}}`
jmurphyau
force-pushed
the
new-get-helper-as-keyword
branch
6 times, most recently
from
ff1ca3e
to
37a39a4
Compare
|
Any updates here? |
|
This should be good to go.. @mmun? Just need to document it.. |
|
I will merge this but I'm a little sad how complicated it has to be right now. Needs a rebase. |
This commit fixes two issues:
1. When using the {{get}} helper it sometimes wouldn't update correctly.
Because a helper and a keyword are being used, ember is invoking the helper logic and wrapping the stream the get keyword creates in a BuiltInHelperStream - it also would not subscribe the morph to the stream. This subscription is where the error lies.
To fix this the helper has been removed and only keyword logic is implemented.
2. It was previously not possible to use the {{input}} helper with the {{get}} helper - this functionality has now been added using the mut keyword, e.g:
{{input value=(mut (get source path)) type='text'}}
jmurphyau
force-pushed
the
new-get-helper-as-keyword
branch
from
37a39a4
to
de5446f
Compare
|
Rebase done. @mmun is there anything I should do to make it less complicated? |
|
It would require an HTMLBars refactor. Sauce failed, I'll restart it. |
mmun
added a commit
that referenced
this pull request
Jul 16, 2015
[BUGFIX beta] {{get}} helper subscribes to values and can be updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
1: When using the {{get}} helper it sometimes wouldn't update correctly.
Because a helper and a keyword are being used, Ember is invoking the helper logic and wrapping the stream the get keyword creates in a
BuiltInHelperStream- it also would not subscribe the morph to the stream. This subscription is where the error lies.To fix this the helper has been removed and only keyword logic is implemented.
2: It was previously not possible to use the
{{input}}helper with the{{get}}helperThis functionality has now been added using the mut keyword, e.g:
{{input value=(mut (get source path)) type='text'}}This should help with making progress on #4619.