Ember 4.0 Tracking Issue

[MelSumner]

Summary

The purpose of this issue is to provide a way to track the status of the work necessary to ship v.4.0 of Ember.js

The list of issues should be updated to include links to individual issues as they are created. The individual issues should contain more details for each item on this list.

As a reminder: Major versions of Ember do not ship new features- instead, major versions remove previously deprecated features. To read more about Ember's philosophy regarding editions, please see https://emberjs.com/editions/.

Issues

• blocking Remove deprecated features (See Deprecation Cleanup for 4.0 #19617 for open tasks) (includes IE11 removals)
• Tracking for Remove jQuery by Default - Done from the Ember 4.0 perspective.
• 🔒 Ember.assign deprecation implementation Add deprecation warning to Ember.assign #19649
• blocking Deprecation guide for Ember.assign
• 🔒 Ember auto location deprecation implementation Deprecate auto location #19510 - we got this in targeting 4.1
• non-blocking for 4.0 🔒 Deprecation guide for auto Deprecate auto-location ember-learn/deprecation-app#882
• non-blocking: Remove classic examples from API docs
• blocking Make sure we aren't showing deprecated methods in the guides - mostly done except willTransition/didTransition
• blocking Update the optional features guide - has a PR
• blocking Update the Octane upgrade guide - has a PR
• Land [BUGFIX beta] Replace assert.equal in blueprints with assert.strictEqual to appease eslint-plugin-qunit on generation #19825 otherwise newly generated files will error due to the newer version of eslint-plugin-qunit in the 4.0 new project blueprint
• New browser-support policy: One to drop IE11 from Ember Data CI.
• blocking New browser-support policy: Need a canonical place to publish supported browsers, and we need to have the list for 4.0 in hand. And write it into the blog post.
• blocking The implicit injection of the store, which is deprecated, was not deprecated in all cases. @igorT has seen an OSS codebase that broke on 4.0 upgrade because the case was missed. This should be addressed as a release bugfix improving the fidelity of the deprecation. Disable ilios partner test data#7744

Communication

Some of this may happen after release, and is implicitly non-blocking.

• Ember.js website updates. Audit the situation and approve by checking this box.
• Add 4.x section to the deprecation guide Add Ember 4.x section for deprecation guides ember-learn/deprecation-app#898
• Make sure API docs work. They should after release, confirm by checking this box.
• Make sure the Super Rentals app is happy. Check this box the day after we release the final beta of 4.0 and have a green build. https://github.com/ember-learn/super-rentals-tutorial/actions/runs/1451232432
• Ember 4.0 release blog post tracking issue and Pull request

[simonihmig]

@MelSumner you might want to link to emberjs/rfc-tracking#3 for the jQuery removal, which already lists the work to be done for Ember 4.0! Some PRs already underway... 🙂

[MelSumner]

@simonihmig added, thank you!

[simonihmig]

Here's a PR for dropping IE11: #19558 🎉

[nlfurniss]

@MelSumner this PR can be linked to Deprecation guide for Ember.assign 👍

[jenweber]

Hi all, I made some new issues for tracking docs work and the blog post. I added them to the main tracking list above. The learning team is filling in details for these issues over the coming weeks.

[jenweber]

Just a status update, I opened some PRs tonight that take care of the bulk of the guides changes. See ember-learn/guides-source#1730 and https://github.com/ember-learn/super-rentals-tutorial/ and ember-learn/guides-source#1733

This updates the website's description of Octane and FAQ to make it sound less new: ember-learn/ember-website#864

[jenweber]

Another status update, I have a PR open for adding placeholders for missing deprecation guides. These are missing from the 3.x series and not the new deprecations for v4. However we really want these links to be in place in the source code for 4.0.x. ember-learn/deprecation-app#954

[jenweber]

I added a new point to the tracking list: the deprecation workflow isn't catching everything, therefore our story of "resolve all deprecations and you can upgrade smoothly" doesn't work. [Bug] Some Deprecations seem to side-step the deprecation workflow #19753

[mansona]

I found another thing that could possibly go in the Bugs/Blockers section: emberjs/ember-render-modifiers#33

Essentially we recommend the use of ember-render-modifiers in the guides here but that PR is blocking it from being used in Ember Beta (4.0). I don't have permission to edit the tracking issue so could someone else add it for me?

[raido]

Here is a tracking issue for ember-page-title to support v4.0 - ember-cli/ember-page-title#222

[jrjohnson]

Pulling this comment over from the data PR - now that store is not injected the behavior documented for dynamic models as:

If you do not define a model hook for a route, it will default to using Ember Data to look up the record, as shown below:

no longer works because there is no store.

It confusingly errors with the message

Assertion Failed: RouteName has no method "find"

I think this behavior of automatically using the ED store to lookup the model when no model hook is defined needs to be deprecated or else the store needs to be looked up from the container in the default model() hook on routes where it is needed. Otherwise apps with no deprecation warnings which use the current implicit model behavior will error.

[mixonic]

@jrjohnson that error around 'has no method find" should be improved in Ember 4.0.1. Some links:

• [BUGFIX release] Improve assert in default store #19858
• [BUGFIX release] Add model hook in route blueprint #19860

If you explicitly inject a store in 4.0 and have no model hook, implicit record loading from data will still occur. I'm not sure if it is deprecated yet but several people would like to. Regardless, that itself is not a 4.0 release issue. It is merely a poor API we want to deprecate for 5.0.

I hope that closes the loop, I know your comment here was already a bit stale but didn't want to leave it hanging.

[jrjohnson]

Thanks @mixonic, these look good, but don't cover the case of not having a route file at all. In that case pre 4.0 ED would still be used to lookup a model. In 4.0 this doesn't work and the workaround requires creating an empty route class and injecting the store into it. If you do create an otherwise empty route backing file then having it exist only to inject a store looks very strange.

Just for the record we added model hooks where required in our app when we discovered the ED issue and it wasn't a big deal. However it feels like an undocumented BC break to me with no previous deprecation message so I wanted to bring it up at least to improve the documentation for updating to 4.0.

[mixonic]

FWIW we suggest (as in, the assert messages suggests) adding a no-op model hook over an injection. 👍

Agreed it is weird, but the messaging should be acceptable. In 4.0.1+ with no route, you get the improved assert I linked above telling you to add a model hook. If you use the ember generate commands, you get a model hook by default if there is a dynamic segment.

This isn't perfect, I agree we should deprecate the implicit loading entirely, but that needs to aim at 5.0.

Additionally, there should be a deprecation in ember 3.28.7+ when the implicitly injected store was accessed. This was an improvement on the earlier deprecation added specifically to address this exact situation. See #19854 I expect your app would have hit that deprecation.

Perhaps you upgraded before that point release was out? It is definitely something we identified from people upgrading in the wild.

However, there is no breaking change besides the removals. Yes, if you created a new route in ember/data 3.28 with a dynamic segment and no route, the behavior is different than if you do the same in 4.0. That is not a breaking change for existing code (that should trigger the above linked deprecation), it is simply a change of behavior for new code.

[kategengler]

We shipped 4.0!