Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember 4.0 release blog post #1036

Merged
merged 21 commits into from
Dec 20, 2021
Merged

Ember 4.0 release blog post #1036

merged 21 commits into from
Dec 20, 2021

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented Sep 16, 2021 •
edited by mixonic
Loading

This is the starting place for the blog post. Content needs to be filled in by other team members.

Sign-off:

When to merge

  • After all teams have reviewed/signed off
  • After Guides & API docs for v4 are live. Please @ the learning team.

Closes #1013

@jenweber jenweber mentioned this pull request Sep 16, 2021
Closed
19 tasks
@jenweber
Copy link
Contributor Author

jenweber commented Nov 4, 2021

@mixonic do you have anything in progress that you can push up? Feel free to add to this branch directly.

@jenweber jenweber marked this pull request as draft November 19, 2021 19:45
@netlify
Copy link

netlify bot commented Nov 20, 2021 •
edited
Loading

✔️ Deploy Preview for ember-blog ready!

🔨 Explore the source changes: fe494bd

🔍 Inspect the deploy log: https://app.netlify.com/sites/ember-blog/deploys/61c0e7a55df4df000832a33b

😎 Browse the preview: https://deploy-preview-1036--ember-blog.netlify.app

@jenweber
Copy link
Contributor Author

@kategengler @rwjblue I just pushed up a very rough draft. Please review for accuracy and general organization. I am especially looking for feedback about whether to include the major version soapbox. I can edit to to make it shorter. I'm thinking of writing a separate post about release strategy, and would move the bulk of it there. Thank you!

@jenweber
Copy link
Contributor Author

My to-dos:

  • fix typos
  • Make spellchecker happy
  • Add a section with where to get help
  • Link to Octane

@mixonic
Copy link
Contributor

mixonic commented Nov 23, 2021

FYI I have force pushed this branch after rebase.

kategengler
kategengler reviewed Nov 23, 2021
View reviewed changes
content/ember-4-0-released.md Outdated Show resolved Hide resolved
content/ember-4-0-released.md Outdated Show resolved Hide resolved
content/ember-4-0-released.md Outdated Show resolved Hide resolved
MelSumner
MelSumner approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested a few changes but they are non-blockers. It would help to have some clarity on whether or not ember-cli really did add new things in 4.0.

@mixonic mixonic changed the title WIP Ember 4.0 release blog post Ember 4.0 release blog post Dec 20, 2021
@mixonic mixonic marked this pull request as ready for review December 20, 2021 19:44
jenweber and others added 18 commits December 20, 2021 14:58
@jenweber @mixonic
Begin drafting the 4.0 release blog post
7eadd00
@jenweber @mixonic
Rough draft of 4.0 post
60a64c4
@jenweber @mixonic
Add a help section
ea4de4e
@mixonic
Additions and adjustments
4e62f81
@mixonic
Add 4.x tag
5a5cac2
@mixonic
Changes to reflect feedback
16c89ed
@mixonic
Drop npx from serve command
77bfd59
@mixonic
Bump date, mention ember-cli-htmlbars in steps
b48682e
@mixonic
Feedback from @ijlee2
96367b2
@jenweber @mixonic
Learning team edits
30d5cf2 
Typo fix, repair commands,
make the major versions sections shorter
@jenweber @mixonic
Lint fix
f6496eb
@jenweber @kategengler @mixonic
Update content/ember-4-0-released.md
f81e51e 
Co-authored-by: Katie Gengler <[email protected]>
@jenweber @mixonic
Update ember-4-0-released.md
0c7c993
@mixonic
Language tweak for jQuery removal
2568476
@mixonic @MelSumner @bertdeblock
Apply suggestions from code review
d3b10d5 
Co-authored-by: Melanie Sumner <[email protected]>
Co-authored-by: Bert De Block <[email protected]>
@mixonic
Mention CLI changes
ba72390
@mixonic
npm start
b0cfd4e
@mixonic
Update date
988fedc
@mixonic
Copy link
Contributor

mixonic commented Dec 20, 2021

I believe this is actually ready to roll. It has been rebased. Date is set to 2021-12-20.

@mixonic mixonic merged commit 33ef054 into main Dec 20, 2021
@mixonic mixonic deleted the ember-4-release branch December 20, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 left review comments

@bertdeblock bertdeblock bertdeblock left review comments

@MelSumner MelSumner MelSumner approved these changes

@simonihmig simonihmig simonihmig left review comments

@kategengler kategengler kategengler left review comments

@NullVoxPopuli NullVoxPopuli NullVoxPopuli left review comments

@mixonic mixonic mixonic left review comments

@rwjblue rwjblue Awaiting requested review from rwjblue

@igorT igorT Awaiting requested review from igorT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ember 4 release blog post tracking
8 participants
@jenweber @mixonic @NullVoxPopuli @kategengler @simonihmig @MelSumner @bertdeblock @ijlee2