Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Octane and editions description #864

Closed
wants to merge 2 commits into from
Closed

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented Sep 2, 2021

This is part of prep for Ember 4. Not much on this page needed to change.

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Files that got Smaller 🎉:

File raw gzip
ember-website.js -564 B -65 B

Files that stayed the same size 🤷‍:

File raw gzip
blurhash.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
polyfill-evergreen.js 0 B 0 B
polyfill-legacy.js 0 B 0 B
polyfill-shared.js 0 B 0 B
vendor.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B +1 B

Comment on lines +98 to +99
From Ember 3.15 onwards, if you start a new app and use Ember CLI commands like `ember generate component` to create
your files, you are using Octane!
Copy link
Member

@ijlee2 ijlee2 Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if this answer belongs well to the question I'm starting a new app at work. Should I use Octane?.

I was guessing that the answer was added, because there might be people who are unsure if their app is already Octane. How could I check if I am using Octane?

Did I misunderstand your intent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of making this be its own question. Thanks for the suggestion!

@jenweber
Copy link
Contributor Author

jenweber commented Sep 9, 2021

@ijlee2 thank you for all the prose improvements! I still need to split that question out, and then this will be ready for another review/merging.

@github-actions
Copy link

github-actions bot commented Sep 9, 2021

Files that got Smaller 🎉:

File raw gzip
ember-website.js -573 B -84 B

Files that stayed the same size 🤷‍:

File raw gzip
blurhash.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
polyfill-evergreen.js 0 B 0 B
polyfill-legacy.js 0 B 0 B
polyfill-shared.js 0 B 0 B
vendor.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B -1 B

@locks locks self-assigned this Dec 20, 2021
@stale
Copy link

stale bot commented Mar 2, 2022

This pull request has been automatically marked stale. If this pull request is something that still needs work, please add a comment and it will remain open, otherwise it will close in 7 days. You are welcome to open a new pull request if you miss the window. Thanks!

@stale stale bot added the stale label Mar 2, 2022
@stale stale bot closed this Apr 16, 2022
@jenweber jenweber reopened this Apr 18, 2022
@stale stale bot removed the stale label Apr 18, 2022
@github-actions
Copy link

Files that got Bigger 🚨:

File raw gzip
ember-website.js +2.1 kB -161 B
ember-website-fastboot.js +868 B +260 B
ember-website.css +666 B +186 B

Files that stayed the same size 🤷‍:

File raw gzip
blurhash.js 0 B 0 B
polyfill-evergreen.js 0 B 0 B
polyfill-legacy.js 0 B 0 B
polyfill-shared.js 0 B 0 B
vendor.js 0 B 0 B
vendor.css 0 B +6 B

@stale
Copy link

stale bot commented Jul 10, 2022

This pull request has been automatically marked stale. If this pull request is something that still needs work, please add a comment and it will remain open, otherwise it will close in 7 days. You are welcome to open a new pull request if you miss the window. Thanks!

@stale stale bot added the stale label Jul 10, 2022
@jenweber
Copy link
Contributor Author

I’ll have a look at this with fresh perspective to see what can be updated easily

@stale stale bot closed this Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants