Inline promise polyfill fallback. #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh boy, this is the gift that keeps on giving... |
The UMD wrapping that was used by es6-promise was causing issues in certain contexts (see embroider-build/embroider#677). This moves from es6-promise to the same promise polyfill that is used by [email protected] and higher ([email protected] with some tweaks).
rwjblue
force-pushed
the
inline-promise-polyfill
branch
from
d71fe65
to
9084dd9
Compare
|
I there a way we can add tests to ensure this works as expected? |
I tested in a local IE11 VM. There are the same number of failures with this PR as there are on master (the failures are around event ordering with things like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UMD wrapping that was used by es6-promise was causing issues in certain contexts (see embroider-build/embroider#677).
This moves from es6-promise to the same promise polyfill that is used by [email protected] and higher ([email protected] with some tweaks).