Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using dynamic import in FastBoot is broken with @ember/test-helpers#2 #985

Closed
bobisjan opened this issue Feb 2, 2021 · 2 comments
Closed

Using dynamic import in FastBoot is broken with @ember/test-helpers#2 #985

bobisjan opened this issue Feb 2, 2021 · 2 comments

Comments

@bobisjan
Copy link

bobisjan commented Feb 2, 2021

Hi 👋,

when upgrading to the latest @ember/test-helpers#2 (with ember-qunit) the error ReferenceError: document is not defined starts to show up in FastBoot.

I'm not sure where does issue come from, the previous version of this add-on works fine, but I've made a simple repository to demonstrate the issue bobisjan/--ember-document-error@67dceff.
@bobisjan
Copy link
Author

It seems to be fixed in the latest release 2.2.1 by #992 🎉.

@rwjblue
Copy link
Member

rwjblue commented Feb 19, 2021

Awesome, thank you for checking @bobisjan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwjblue @bobisjan