Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when attempting to fillIn / typeIn a readonly form control #779

Merged
merged 2 commits into from
Apr 21, 2020

Conversation

ro0gr
Copy link
Contributor

@ro0gr ro0gr commented Mar 9, 2020

fixes: #680
based on #741

@ro0gr ro0gr changed the title Disallow edit readonly form controls Respect "readonly" Apr 10, 2020
@ro0gr ro0gr changed the title Respect "readonly" Respect "readonly" in "fillIn" and "typeIn" Apr 10, 2020
}

if ('readOnly' in element && element.readOnly) {
throw new Error(`Can not \`fillIn\` readonly ${element}`);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: change to display user selector if passed

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, will need a rebase once we land #741

@btecu
Copy link

btecu commented Apr 20, 2020

Thanks for working on this @ro0gr.

@rwjblue rwjblue merged commit 3d8d54c into emberjs:master Apr 21, 2020
@rwjblue rwjblue changed the title Respect "readonly" in "fillIn" and "typeIn" Error when attempting to fillIn / typeIn a readonly form control May 5, 2020
@rwjblue rwjblue added breaking and removed bug labels May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fillIn ignores the disabled property on inputs
3 participants