Disallow edit readonly form controls

emberjs · Mar 9, 2020 · 85bf11d · 85bf11d
1 parent 6c063ff
commit 85bf11d
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 0 deletions.
diff --git a/addon-test-support/@ember/test-helpers/dom/fill-in.ts b/addon-test-support/@ember/test-helpers/dom/fill-in.ts
@@ -47,6 +47,10 @@ export default function fillIn(target: Target, text: string): Promise<void> {
         throw new Error(`Can not \`fillIn\` disabled ${element}`);
       }
 
+      if ('readOnly' in element && element.readOnly) {
+        throw new Error(`Can not \`fillIn\` readonly ${element}`);
+      }
+
       __focus__(element);
 
       element.value = text;

diff --git a/addon-test-support/@ember/test-helpers/dom/type-in.ts b/addon-test-support/@ember/test-helpers/dom/type-in.ts
@@ -62,6 +62,10 @@ export default function typeIn(target: Target, text: string, options: Options =
       throw new Error(`Can not \`typeIn\` disabled ${element}`);
     }
 
+    if ('readOnly' in element && element.readOnly) {
+      throw new Error(`Can not \`typeIn\` readonly ${element}`);
+    }
+
     __focus__(element);
 
     let { delay = 50 } = options;

diff --git a/tests/unit/dom/fill-in-test.js b/tests/unit/dom/fill-in-test.js
@@ -55,6 +55,17 @@ module('DOM Helper: fillIn', function(hooks) {
     );
   });
 
+  test('filling in a readonly element', async function(assert) {
+    element = buildInstrumentedElement('input');
+    element.setAttribute('readonly', true);
+
+    await setupContext(context);
+    assert.rejects(
+      fillIn(`#${element.id}`, 'foo'),
+      new Error('Can not `fillIn` readonly [object HTMLInputElement]')
+    );
+  });
+
   test('rejects if selector is not found', async function(assert) {
     element = buildInstrumentedElement('div');
 

diff --git a/tests/unit/dom/type-in-test.js b/tests/unit/dom/type-in-test.js
@@ -136,6 +136,17 @@ module('DOM Helper: typeIn', function(hooks) {
     );
   });
 
+  test('typing in a readonly element', async function(assert) {
+    element = buildInstrumentedElement('input');
+    element.setAttribute('readonly', '');
+
+    await setupContext(context);
+    assert.rejects(
+      typeIn(`#${element.id}`, 'foo'),
+      new Error('Can not `typeIn` readonly [object HTMLInputElement]')
+    );
+  });
+
   test('rejects if selector is not found', async function(assert) {
     element = buildInstrumentedElement('div');