fix: make emergent unsupported behaviors safer in prod

.eslintignore

@@ -5,6 +5,7 @@
 
 # compiled output
 **/dist/
+**/dist-*/
 **/dist-control/
 **/dist-experiment/
 **/tmp/

.gitignore

@@ -5,6 +5,7 @@
 /packages/-ember-data/docs/
 concat-stats-for
 dist
+dist-*
 tmp
 packages/tracking/addon
 packages/request/addon

packages/json-api/src/-private/cache.ts

@@ -358,8 +358,8 @@ export default class JSONAPICache implements Cache {
       const rels = graph.identifiers.get(identifier);
       if (rels) {
         Object.keys(rels).forEach((key) => {
-          const rel = rels[key]!;
-          if (rel.definition.isImplicit) {
+          const rel = rels[key];
+          if (!rel || rel.definition.isImplicit) {
             return;
           }
           relationships[key] = (rel as ManyRelationship | BelongsToRelationship).getData();
@@ -927,6 +927,13 @@ export default class JSONAPICache implements Cache {
    */
   getAttr(identifier: StableRecordIdentifier, attr: string): unknown {
     const cached = this.__peek(identifier, true);
+    assert(`Cannot retrieve attributes for identifier ${identifier} as it is not present in the cache`, cached);
+
+    // in Prod we try to recover when accessing something that
+    // doesn't exist
+    if (!cached) {
+      return undefined;
+    }
     if (cached.localAttrs && attr in cached.localAttrs) {
       return cached.localAttrs[attr];
     } else if (cached.inflightAttrs && attr in cached.inflightAttrs) {
@@ -981,8 +988,17 @@ export default class JSONAPICache implements Cache {
    * @returns { <field>: [<old>, <new>] }
    */
   changedAttrs(identifier: StableRecordIdentifier): ChangedAttributesHash {
+    const cached = this.__peek(identifier, false);
+    assert(`Cannot retrieve changed attributes for identifier ${identifier} as it is not present in the cache`, cached);
+
+    // in Prod we try to recover when accessing something that
+    // doesn't exist
+    if (!cached) {
+      return Object.create(null);
+    }
+
     // TODO freeze in dev
-    return this.__peek(identifier, false).changes || Object.create(null);
+    return cached.changes || Object.create(null);
   }
 
   /**
@@ -995,6 +1011,13 @@ export default class JSONAPICache implements Cache {
    */
   hasChangedAttrs(identifier: StableRecordIdentifier): boolean {
     const cached = this.__peek(identifier, true);
+    assert(`Cannot retrieve changed attributes for identifier ${identifier} as it is not present in the cache`, cached);
+
+    // in Prod we try to recover when accessing something that
+    // doesn't exist
+    if (!cached) {
+      return false;
+    }
 
     return (
       (cached.inflightAttrs !== null && Object.keys(cached.inflightAttrs).length > 0) ||

packages/model/src/-private/legacy-relationships-support.ts

@@ -166,14 +166,13 @@ export class LegacySupport {
       if (relatedIdentifier === null) {
         return null;
       } else {
-        let toReturn = store._instanceCache.getRecord(relatedIdentifier);
         assert(
           `You looked up the '${key}' relationship on a '${identifier.type}' with id ${
             identifier.id || 'null'
           } but some of the associated records were not loaded. Either make sure they are all loaded together with the parent record, or specify that the relationship is async (\`belongsTo(<type>, { async: true, inverse: <inverse> })\`)`,
-          toReturn === null || store._instanceCache.recordIsLoaded(relatedIdentifier, true)
+          store._instanceCache.recordIsLoaded(relatedIdentifier, true)
         );
-        return toReturn;
+        return store._instanceCache.getRecord(relatedIdentifier);
       }
     }
   }

packages/store/src/-private/caches/instance-cache.ts

@@ -264,7 +264,13 @@ export class InstanceCache {
             }
           );
         }
-        assert(`Cannot create a record for ${identifier.type + identifier.id} (${identifier.lid}) as no resource data exists`, cache.peek(identifier));
+        assert(
+          `Cannot create a record for ${identifier.type + ':' + String(identifier.id)} (${
+            identifier.lid
+          }) as no resource data exists`,
+          // @ts-expect-error managedVersion is private and debug only
+          Boolean(cache.managedVersion === '1' || cache.peek(identifier))
+        );
         record = this.store.instantiateRecord(
           identifier,
           properties || {},
@@ -273,7 +279,12 @@ export class InstanceCache {
           this.store.notifications
         );
       } else {
-        assert(`Cannot create a record for ${identifier.type + identifier.id} (${identifier.lid}) as no resource data exists`, cache.peek(identifier));
+        assert(
+          `Cannot create a record for ${identifier.type + ':' + String(identifier.id)} (${
+            identifier.lid
+          }) as no resource data exists`,
+          cache.peek(identifier)
+        );
         record = this.store.instantiateRecord(identifier, properties || {});
       }