fix: make emergent unsupported behaviors safer in prod #9120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
🏷️ test
3 tasks
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In older versions of EmberData (<=4.6), accessing a sync belongsTo or sync hasMany relationship before its related data was loaded while in production mode would lead to buggy behaviors but would not necessarily immediately crash the app.
In new versions of EmberData, this same pattern generally would fail immediately.
Some of these failures were eventually recoverable as long as the app caught the error, others were not. This PR makes 4.12 behave as close as is feasible to 4.6 in these regards.