Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make implicit relationship teardown following delete of related record safe #8705

Merged
merged 2 commits into from
Jul 12, 2023
Merged

fix: make implicit relationship teardown following delete of related record safe #8705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
189825b
add tests for various unload interleaving scenarios
runspired Jul 12, 2023
4540dd0
more tests and a fix
runspired Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/graph/src/-private/graph/graph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,11 @@ export class Graph {
const keys = Object.keys(relationships);
for (let i = 0; i < keys.length; i++) {
const relationship = relationships[keys[i]] as RelationshipEdge;
// account for previously unloaded relationships
// typically from a prior deletion of a record that pointed to this one implicitly
if (relationship === undefined) {
continue;
}
assert(`Expected a relationship`, relationship);
if (relationship.definition.inverseIsAsync) {
return false;
Expand Down
Loading