fix: make implicit relationship teardown following delete of related record safe #8705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
🎯 beta
jrjohnson
pushed a commit
to jrjohnson/ember-data
that referenced
this pull request
Jul 28, 2023
Merged
runspired
added a commit
that referenced
this pull request
Jul 28, 2023
* fix: @ember-data/debug should declare its peer-dependency on @ember-data/store (#8703) * fix: de-dupe coalescing when includes or adapterOptions is present but still use findRecord (#8704) * fix: make implicit relationship teardown following delete of related record safe (#8705) * fix: catch errors during didCommit in DEBUG (#8708) --------- Co-authored-by: Chris Thoburn <[email protected]>
jrjohnson
pushed a commit
to jrjohnson/ember-data
that referenced
this pull request
Jul 28, 2023
runspired
added a commit
that referenced
this pull request
Jul 28, 2023
* fix: @ember-data/debug should declare its peer-dependency on @ember-data/store (#8703) * fix: de-dupe coalescing when includes or adapterOptions is present but still use findRecord (#8704) * fix: make implicit relationship teardown following delete of related record safe (#8705) * fix: catch errors during didCommit in DEBUG (#8708) --------- Co-authored-by: Chris Thoburn <[email protected]>
3 tasks
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8702
also adds a bunch tests of various ordered unload/delete calls to try to spread a broader net for detecting this sort of issue.