Land previously failing block-indentation tests for lines starting with
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, no. This is tricky indeed... |
bjornharrtell
pushed a commit
to bjornharrtell/ember-template-lint
that referenced
this pull request
Jun 11, 2019
* chore(package): Bump to [email protected] * chore(package): Bump to [email protected] * chore(package): Bump to [email protected]
…emplate-lint#120) - ` ` followed by text (` Hello`) seems to interpret the ` ` as a space and fails: `Expected ' Hello\n' to be at an indentation of 2 but was found at 3."` - ` ` followed by HTML (` <div></div>`) seems to interpret the ` ` as six separate whitespace characters and fails: `Expected '<div>' to be at an indentation of 2 but was found at 8.`
rwjblue
force-pushed
the
failing-test-for-120
branch
from
90e9c82
to
92c5468
Compare
rwjblue
approved these changes
Nov 3, 2019
rwjblue
changed the title
block-indentation tests for lines starting with
|
@rwjblue folks shouldn't be indenting paragraph text with whitespace, they should be using CSS (attach a class to the element and put padding in it). It's the whole point of the rule. |
|
@MelSumner - That is definitely not the point of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #120:
followed by text ( Hello) seems to interpret the as a space and fails:Expected ' Hello\n' to be at an indentation of 2 but was found at 3." followed by HTML ( <div></div>) seems to interpret the as six separate whitespace characters and fails:Expected '<div>' to be at an indentation of 2 but was found at 8.