-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect indentation on line starting with #120
Comments
What would be the expectation here? Thanks! |
It's looking like ember-template-lint is treating the I'd expect both of the following to pass linting, but currently only the second one does: {{#if foo}}
bar
{{/if}} {{#if foo}}
→bar
{{/if}} |
Agreed. I am unsure why |
…emplate-lint#120) - ` ` followed by text (` Hello`) seems to interpret the ` ` as a space and fails: `Expected ' Hello\n' to be at an indentation of 2 but was found at 3."` - ` ` followed by HTML (` <div></div>`) seems to interpret the ` ` as six separate whitespace characters and fails: `Expected '<div>' to be at an indentation of 2 but was found at 8.`
Confirmed that it's still happening on the latest version and submitted failing tests in #184. |
…nent and aligns it to bottom left for proper display (ember-template-lint#120)
We can fix it now! We need to update our usage of @glimmer/compiler to use the new See glimmerjs/glimmer-vm#938 for background on that new parsing mode. |
…emplate-lint#120) - ` ` followed by text (` Hello`) seems to interpret the ` ` as a space and fails: `Expected ' Hello\n' to be at an indentation of 2 but was found at 3."` - ` ` followed by HTML (` <div></div>`) seems to interpret the ` ` as six separate whitespace characters and fails: `Expected '<div>' to be at an indentation of 2 but was found at 8.`
Linting a template with a segment like the following incorrectly flags the indentation:
with
The text was updated successfully, but these errors were encountered: