Do not error when logging long module names. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis is unhappy |
|
👍 I just ran into this today too |
|
Travis's problem was that we broke Ember canary builds. Fix submitted in emberjs/ember.js#4594. Will re-trigger this build once Travis finishes. |
stefanpenner
added a commit
that referenced
this pull request
Mar 24, 2014
Do not error when logging long module names.
kratiahuja
pushed a commit
to kratiahuja/ember-resolver
that referenced
this pull request
Aug 5, 2016
Throw when accessing parent module of root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35.
I'll add some tests for the logging when I have a free minute.