Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolver breaks when logging long names #35

Closed
KnownSubset opened this issue Mar 24, 2014 · 3 comments · Fixed by #36
Closed

Resolver breaks when logging long names #35

KnownSubset opened this issue Mar 24, 2014 · 3 comments · Fixed by #36

Comments

@KnownSubset
Copy link

When logging the resolving of application elements.

Ember.ENV.LOG_MODULE_RESOLVER = true;

The logging can fail when you have long component/view/template names. The logging code expects the parsedName.fullName.length to be <= 40. If not, then the logging hits an invalid array length exception.

screen shot 2014-03-24 at 9 46 12 am

The resolver was looking up "template:components/update-aware-text-field"
@stefanpenner
Copy link
Contributor

o_0) crazy, this is quite unexpected.

@rwjblue
Copy link
Member

rwjblue commented Mar 24, 2014

Agreed. Looking at the code now to see what is going on...

rwjblue added a commit to rwjblue/ember-jj-abrams-resolver that referenced this issue Mar 24, 2014
@rwjblue
Do not error when logging long module names.
d461e7c 
Fixes ember-cli#35.
@rwjblue rwjblue mentioned this issue Mar 24, 2014
Merged
@rwjblue
Copy link
Member

rwjblue commented Mar 24, 2014

Addressed by #36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not error when logging long module names. rwjblue/ember-jj-abrams-resolver
3 participants
@stefanpenner @rwjblue @KnownSubset