Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading template issue #13

Closed
knownasilya opened this issue Jan 9, 2014 · 1 comment
Closed

Loading template issue #13

knownasilya opened this issue Jan 9, 2014 · 1 comment

Comments

@knownasilya
Copy link

I'm not sure where this needs to go, here or ember issues, since I'm unsure where the problem lies.

Recently I switched to EAK, and now my loading routes are mostly broken. I have the following template (along with route, etc for non loading templates):

loading
map
map.index
map.loading
map.location
map.location.index

Now none of the loading routes work in the application, except for one. When I load map.location from the url, the loading route activates (only from url). I'm using 1.3.0 of Ember, and I tried to recreate the problem, but no luck.

I made sure that the templates.js contains the loading templates, and it does. It just doesn't make sense why it would only load in that case.

Here's a fork of EAK that has something close. When you enter / the main loading template shows, from there if you go to posts or post it will show that same loading template, this also works from url. Now while you are in posts or post, and you click to the other, no loading appears.

@rwjblue
Copy link
Member

rwjblue commented Jan 20, 2014

OK, I finally tracked this down. The issue was that the container (in Ember) was not calling normalize properly. We provide a custom normalize function that translates the period into a forward-slash, but in Ember 1.3.1 calling container.has did not normalize. This was fixed in emberjs/ember.js@2a423c6, which is now in 1.4.0-beta.2. I submitted a PR to your example fork with the bower.json changes needed to resolve this (https://github.com/knownasilya/ember-app-kit/pull/1).

Closing here for now, since it is resolved upstream.

@rwjblue rwjblue closed this as completed Jan 20, 2014
rwjblue added a commit to rwjblue/ember-app-kit that referenced this issue Jan 20, 2014
Ember 1.3.1 has an issue that prevents loading/error substates from
working properly (see [detailed
comment](ember-cli/ember-resolver#13 (comment))).

This was fixed upstream and is working properly on Ember 1.4.0-beta.2.
taras pushed a commit to taras/ember-app-kit that referenced this issue Jan 23, 2014
Ember 1.3.1 has an issue that prevents loading/error substates from
working properly (see [detailed
comment](ember-cli/ember-resolver#13 (comment))).

This was fixed upstream and is working properly on Ember 1.4.0-beta.2.
thaume pushed a commit to thaume/emberjs-es6-modules that referenced this issue Feb 6, 2014
Ember 1.3.1 has an issue that prevents loading/error substates from
working properly (see [detailed
comment](ember-cli/ember-resolver#13 (comment))).

This was fixed upstream and is working properly on Ember 1.4.0-beta.2.
kratiahuja pushed a commit to kratiahuja/ember-resolver that referenced this issue Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants