Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes from properties in .eslintrc.js files #123

Merged

Conversation

BrianSipple
Copy link
Collaborator

My OCD couldn't help itself 😀.

I noticed we were being inconsistent with the use of property quotes in our .eslintrc.js files, so I standardized everything to no-quotes.

A lot of .eslintrc.js files in the wild seem to look this way -- my guess is due to the transition from .eslintrc.json a while back -- but FWIW the ESLint team appears to be writing their .js's quoteless.

@alexlafroscia alexlafroscia merged commit ea983a9 into ember-cli:master Sep 14, 2016
@alexlafroscia
Copy link
Collaborator

All for keeping it clean!

Turbo87 pushed a commit that referenced this pull request Oct 14, 2018
Bumps [ember-cli-htmlbars](https://github.com/ember-cli/ember-cli-htmlbars) from 2.0.2 to 3.0.1.
<details>
<summary>Commits</summary>

- [`48a5b69`](ember-cli/ember-cli-htmlbars@48a5b69) release v3.0.1 🎉
- [`fcf265a`](ember-cli/ember-cli-htmlbars@fcf265a) fix memory leak (adapted from [**arthirm**](https://github.com/arthirm)’s https://github.com/ember-cli/ember-c...
- [`28d825f`](ember-cli/ember-cli-htmlbars@28d825f) Merge pull request [#124](https://github-redirect.dependabot.com/ember-cli/ember-cli-htmlbars/issues/124) from ember-cli/upgrades
- [`c54e610`](ember-cli/ember-cli-htmlbars@c54e610) Bump deps
- [`88204ba`](ember-cli/ember-cli-htmlbars@88204ba) release v3.0.0 🎉
- [`c1224fb`](ember-cli/ember-cli-htmlbars@c1224fb) Merge pull request [#123](https://github-redirect.dependabot.com/ember-cli/ember-cli-htmlbars/issues/123) from ember-cli/improve-tests
- [`e56e8e1`](ember-cli/ember-cli-htmlbars@e56e8e1) [fixes #113] Make an actual add-on so it can do comprehensive tests of itself
- [`eb2fe15`](ember-cli/ember-cli-htmlbars@eb2fe15) release v2.0.4 🎉
- [`40c02f9`](ember-cli/ember-cli-htmlbars@40c02f9) Merge pull request [#122](https://github-redirect.dependabot.com/ember-cli/ember-cli-htmlbars/issues/122) from ember-cli/remove-bower
- [`a860e25`](ember-cli/ember-cli-htmlbars@a860e25) Upgrade deps
- Additional commits viewable in [compare view](ember-cli/ember-cli-htmlbars@vv2.0.2...v3.0.1)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-cli-htmlbars&package-manager=npm_and_yarn&previous-version=2.0.2&new-version=3.0.1)](https://dependabot.com/compatibility-score.html?dependency-name=ember-cli-htmlbars&package-manager=npm_and_yarn&previous-version=2.0.2&new-version=3.0.1)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

Dependabot will **not** automatically merge this PR because it includes a major update to a development dependency.

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Turbo87 pushed a commit that referenced this pull request Nov 9, 2018
Bumps [qunit-dom](https://github.com/simplabs/qunit-dom) from 0.7.1 to 0.8.0.
<details>
<summary>Changelog</summary>

*Sourced from [qunit-dom's changelog](https://github.com/simplabs/qunit-dom/blob/master/CHANGELOG.md).*

> ## v0.8.0 (2018-09-06)
> 
> #### 💥 Breaking Change
> * [#105](https://github-redirect.dependabot.com/simplabs/qunit-dom/pull/105) Collapse whitespace for `includesText` assertion ([[**brookjordan**](https://github.com/brookjordan)](https://github.com/brookjordan))
> * [#126](https://github-redirect.dependabot.com/simplabs/qunit-dom/pull/126) Update Node version requirement to `6.* || 8.* || >= 10.*` ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> * [#117](https://github-redirect.dependabot.com/simplabs/qunit-dom/pull/117) Bump broccoli-merge-trees from 2.0.0 to 3.0.1 ([[**dependabot**](https://github.com/dependabot)[bot]](https://github.com/apps/dependabot))
> 
> #### 📝 Documentation
> * [#103](https://github-redirect.dependabot.com/simplabs/qunit-dom/pull/103) README: Add `import` documentation ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> #### Committers: 2
> - Brook Jordan ([[**brookjordan**](https://github.com/brookjordan)](https://github.com/brookjordan))
> - Tobias Bieniek ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
</details>
<details>
<summary>Commits</summary>

- [`a908f3c`](mainmatter/qunit-dom@a908f3c) v0.8.0
- [`87c3dcf`](mainmatter/qunit-dom@87c3dcf) Update Changelog
- [`fbdaa18`](mainmatter/qunit-dom@fbdaa18) Bump broccoli-merge-trees from 2.0.0 to 3.0.1 ([#117](https://github-redirect.dependabot.com/simplabs/qunit-dom/issues/117))
- [`43f8d70`](mainmatter/qunit-dom@43f8d70) Merge pull request [#126](https://github-redirect.dependabot.com/simplabs/qunit-dom/issues/126) from Turbo87/bump-node-req
- [`519815b`](mainmatter/qunit-dom@519815b) Update Node version requirement to `6.* || 8.* || >= 10.*`
- [`92223aa`](mainmatter/qunit-dom@92223aa) Bump rollup from 0.49.2 to 0.65.0 ([#123](https://github-redirect.dependabot.com/simplabs/qunit-dom/issues/123))
- [`56c0f7e`](mainmatter/qunit-dom@56c0f7e) Merge pull request [#124](https://github-redirect.dependabot.com/simplabs/qunit-dom/issues/124) from simplabs/dependabot/npm_and_yarn/lerna-changelog...
- [`140708a`](mainmatter/qunit-dom@140708a) Bump lerna-changelog from 0.6.0 to 0.8.0
- [`0f7e252`](mainmatter/qunit-dom@0f7e252) Bump babel-plugin-transform-es2015-modules-commonjs from 6.26.0 to 6.26.2 ([#121](https://github-redirect.dependabot.com/simplabs/qunit-dom/issues/121))
- [`62c7456`](mainmatter/qunit-dom@62c7456) Bump ember-cli-qunit from 4.0.1 to 4.3.2 ([#122](https://github-redirect.dependabot.com/simplabs/qunit-dom/issues/122))
- Additional commits viewable in [compare view](mainmatter/qunit-dom@v0.7.1...v0.8.0)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=qunit-dom&package-manager=npm_and_yarn&previous-version=0.7.1&new-version=0.8.0)](https://dependabot.com/compatibility-score.html?dependency-name=qunit-dom&package-manager=npm_and_yarn&previous-version=0.7.1&new-version=0.8.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

Dependabot will **not** automatically merge this PR because this dependency is pre-1.0.0.

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants