ESLint test generator only works with QUnit

[nucleartide]

The docs say that things should "Just Work", but that doesn't seem to be the case when I'm using ember-cli-eslint together with ember-cli-mocha. It seems to me like the default test generator only returns QUnit tests for linting, never Mocha tests.

Using that as an example, I wrote a test generator for Mocha:

var jsStringEscape = require('js-string-escape')
var EmberApp = require('ember-cli/lib/broccoli/ember-app')

function render(errors) {
  if (!errors) return ''
  return errors.map(err => `${err.line}:${err.column} - ${err.message} (${err.ruleId})`).join(jsStringEscape('\n'))
}

function eslintTestGenerator(relativePath, errors) {
  const pass = !errors || errors.length === 0
  const errs = render(errors)
  return `
    import Chai from 'chai'
    import { describe, it } from 'mocha'

    const { assert } = Chai

    describe('${relativePath}', function() {
      it('should pass ESLint', function() {
        assert.ok(${pass}, '${relativePath + ' should pass ESLint.' + jsStringEscape('\n\n' + errs + '\n\n')}')
      })
    })
  `
}

module.exports = function(defaults) {
  var app = new EmberApp(defaults, {
    eslint: {
      testGenerator: eslintTestGenerator
    }
  })
}

I'm not entirely sure how this could be fixed - should the test generator functions be moved to their respective Ember addons (ember-cli-qunit and ember-cli-mocha)? This was very, very frustrating to see upon installing ember-cli-mocha.

(Also, the test generator function above requires Node 4+, for those ES6 features.)

[alexlafroscia]

Which version of ember-cli are you using? With the lastest versions of ember-cli, ember-cli-eslint and ember-cli-mocha it will all "just work" like it should. Update those dependencies if you're seeing issues and it should take care of things.

[nucleartide]

Just tried on a fresh project, see the pic below. Here's the repo: link.

It doesn't bombard me with loads of linting errors like it did in my app (since my app has lots of files 😄 ) , but it does still generate JSHint test cases for whatever reason.

node version: v4.2.2
npm version: 2.14.7
ember-cli version: 2.7.0
ember-cli-mocha version: 0.10.4
ember-cli-eslint version: 1.7.0

[alexlafroscia]

Did you also uninstall ember-cli-jshint? It will override the eslint config and you'll see that output. This will be fixed once #91 is pulled in, which will uninstall jshint and the config files for it on installation of ember-cli-eslint. For some reason, if both are present, Mocha seems to take JSHint over ESLint (not sure if by an explicit preference or just the order that things are loaded).

[nucleartide]

Ah, whoops! That is it, I must have been confused by my commit message.

Amazingly, it also works in my current app if I comment out my custom test generator. Maybe yesterday was just a bad day...

Thanks for the help! 😄

[alexlafroscia]

Yeah, it looks like jshint is still in there.

Not problem! Happy to. Actually just had this same problem at work with a new app, so I recognized the issue.