Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for moduleForAcceptance #199

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Conversation

scalvert
Copy link
Contributor

@scalvert scalvert commented Aug 22, 2020

This PR prepares for the potential of deprecating the a11yAuditIf helper. This helper can be merged into a11yAudit by allowing it to accept another optional parameter: URL. This allows for two things:

  1. The aforementioned deprecation of an extra, largely unnecessary API (simplification)
  2. The removal of the getLocation function, which returns window.location and exists only to provide a stubbing mechanism for the getUrlParameter function. By adding an extra URL param to a11yAudit, we can simply test that function by passing in the required value, and provide the default as window.location.

⚠️ This change also includes a breaking change that removes support for older test infra versions (folks using the long deprecated moduleForAcceptance test system) by removing window.a11yAudit support.

addon-test-support/audit.ts Show resolved Hide resolved
addon-test-support/audit.ts Show resolved Hide resolved
@rwjblue rwjblue merged commit cd1a8a6 into ember-a11y:master Aug 24, 2020
@rwjblue rwjblue changed the title Refactors param normalization in a11yAudit Drop support for moduleForAcceptance Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants