Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing rest args to a11yAuditIf to specific parameters #198

Closed
scalvert opened this issue Aug 21, 2020 · 1 comment
Closed

Consider changing rest args to a11yAuditIf to specific parameters #198

scalvert opened this issue Aug 21, 2020 · 1 comment

Comments

@scalvert
Copy link
Contributor

There's no reason for us to have to accept rest args to a11yAuditIf. We should convert to the specific args that axe.run requires.

During this, we should seek to remove the getLocation API, which is unnecessary (we can just provide a URL param to the a11yAuditIf function instead.
@scalvert scalvert changed the title Change rest args to a11yAuditIf to specific parameters Consider changing rest args to a11yAuditIf to specific parameters Aug 22, 2020
@scalvert
Copy link
Contributor Author

scalvert commented Sep 4, 2020

Fixed in #199.

@scalvert scalvert closed this as completed Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scalvert