Upgrade Ember CLI to 3.12 LTS #138
Conversation
I'm going to commit these suggested changes- we can roll back if we need to. Co-Authored-By: MelSumner <[email protected]>
Co-Authored-By: MelSumner <[email protected]>
Co-Authored-By: MelSumner <[email protected]>
Co-Authored-By: MelSumner <[email protected]>
Co-Authored-By: MelSumner <[email protected]>
…11y/ember-a11y-testing into smassa/upgrade-ember-cli
upgrade ember cli to 3.8 LTS
# Conflicts: # package-lock.json # tests/acceptance/a11y-audit-test.js # tests/integration/instance-initializers/axe-component-test.js # tests/unit/instance-initializers/violations-helper-test.js # tests/unit/utils/concurrent-axe-test.js # tests/unit/utils/violations-helper-test.js # yarn.lock
|
@MelSumner @rwjblue #120 seem to be complete, please let me know if anything else left to get this in as I'm happy to push this over the line |
|
CI seems unhappy, mind taking a look? |
|
looking into CI issues and push updates |
README.md
Outdated
| Compatibility | ||
| ------------------------------------------------------------------------------ | ||
|
|
||
| * Ember.js v1.13 or above |
There was a problem hiding this comment.
We should change this to 2.18 (since that is all we are testing)
package.json
Outdated
| "sass": "^1.17.3" | ||
| }, | ||
| "engines": { | ||
| "node": ">= 4" | ||
| "node": "8.* || >= 10.*" |
There was a problem hiding this comment.
| "node": "8.* || >= 10.*" | |
| "node": "8.* || 10.* || >= 12" |
There was a problem hiding this comment.
@rwjblue could you please advice if we still need registerAsyncHelper() in addon-test-support/audit.js for "older"/global tests helpers support?
Ya, I'd say not. Since this PR will already need to be a major bump, we can drop that helper also. |
thanks for confirming, |
|
@drewlee - I think you've been handling releases lately? Just wanted to point out that this one will require a major version bump (dropping Node < 8, Ember < 2.18, ember-cli < 2.13). |
|
@rwjblue Yeah, I can merge this PR and publish a new version this week. Thanks for the heads up. |
Continuation of #120, should unblock #123