Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade ember cli to 3.8 LTS #120

Merged
merged 17 commits into from
May 15, 2019
Merged

Conversation

EndangeredMassa
Copy link
Contributor

@EndangeredMassa EndangeredMassa commented Apr 2, 2019

I used ember-cli-update (and manual changes) to upgrade this repo to ember-cli 3.4, which is the most recent LTS release.

The test suite still passes locally and I manually linked this to a local app, which also still worked.

We still need to:

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delays here @EndangeredMassa. I did a quick pass after reviewing the CI failures with some inline suggestions. There is one that will require a bit more hand tweaking on your end (the "in a jQuery context" test), but I tried to explain what needed to change.

I think that with these changes, CI should pass...

tests/integration/helpers/a11y-audit-if-test.js Outdated Show resolved Hide resolved
tests/integration/helpers/a11y-audit-if-test.js Outdated Show resolved Hide resolved
tests/integration/helpers/a11y-audit-test.js Outdated Show resolved Hide resolved
tests/integration/helpers/a11y-audit-test.js Outdated Show resolved Hide resolved
tests/integration/helpers/a11y-audit-test.js Outdated Show resolved Hide resolved
tests/integration/helpers/a11y-audit-test.js Outdated Show resolved Hide resolved
@MelSumner
Copy link
Member

@EndangeredMassa I updated to 3.8 which is now latest LTS

@MelSumner MelSumner changed the title upgrade ember cli to 3.4 LTS upgrade ember cli to 3.8 LTS May 6, 2019
@MelSumner
Copy link
Member

after merging this, we'll need to do a major version bump.

@MelSumner MelSumner requested a review from rwjblue May 6, 2019 16:40
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this branch so it uses 3.8 LTS instead of 3.4, updated ember-try and travis config, and added the jQuery check that @rwjblue suggested. Thank you for working on this, @EndangeredMassa !

@MelSumner
Copy link
Member

@rwjblue do you think this is okay to merge now?

package.json Outdated Show resolved Hide resolved
tests/integration/helpers/a11y-audit-test.js Outdated Show resolved Hide resolved
tests/unit/utils/concurrent-axe-test.js Outdated Show resolved Hide resolved
@MelSumner MelSumner requested a review from rwjblue May 14, 2019 14:45
@MelSumner MelSumner merged commit 4fede46 into smassa/upgrade-deps May 15, 2019
@sivakumar-kailasam sivakumar-kailasam deleted the smassa/upgrade-ember-cli branch August 3, 2019 06:53
@drewlee
Copy link
Contributor

drewlee commented Sep 4, 2019

These changes are preventing #123 from moving forward. I don't have full context, but @MelSumner, @EndangeredMassa, is this stable to merge with the main branch?

@SergeAstapov
Copy link
Contributor

@MelSumner @EndangeredMassa @drewlee created #138 with upgrade to 3.12. Happy to help push it over the line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants