Merged
Conversation
Contributor
KennethEnevoldsen
left a comment
KennethEnevoldsen
left a comment
There was a problem hiding this comment.
Great with a first iteration
Should this a method on the AbsTaskClassification? I could also see the argument for not doing it (keeping it as a hidden thing until we have a decent implementation across tasks)
Comment on lines
25
to
26
| logger.info( | ||
| f"[deduplicate] kept={len(indices_to_keep)}, removed={len(dataset) - len(indices_to_keep)}" |
Contributor
There was a problem hiding this comment.
wouldn't you rather want 10/1000 removed (10 duplicates removed out of all the documents 1000)
Contributor
There was a problem hiding this comment.
(would probably do this generally across
| return test_dataset.select(indices) | ||
|
|
||
|
|
||
| def filter_controversial( |
Contributor
There was a problem hiding this comment.
name to filter_unclear_label
Contributor
|
Not sure if this closes #3672 (I could see us merging in this partial solution and expanding upon it - it us currently "private" so it shouldn't cause in issues) |
KennethEnevoldsen
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #3672
For now, this is MVP version of cleaning. I've added it for now because I needed to filter #3607. I'm not sure what is best way to implement it.
task.filter_data(["filter1", "filter2", ...]), but this would probably hard to use.