dataset: Add hebrew v3 #3607
Merged
dataset: Add hebrew v3 #3607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KennethEnevoldsen
left a comment
KennethEnevoldsen
left a comment
There was a problem hiding this comment.
Should we just run a model on both datasets to compare
I am kinda unsure how about the differences in the data
Contributor
There was a problem hiding this comment.
We need to add superseeded_by
Member
Author
There was a problem hiding this comment.
V1 is already superseeded_by v2
Contributor
There was a problem hiding this comment.
v2 needs a superseeded_by v3
Member
Author
There was a problem hiding this comment.
Then we should clenup it as in #2900, but I can't find script for this
Contributor
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Maybe. Try to run this too
Member
Author
|
Results for
|
Contributor
|
hmm would have expected it would have gotten better |
Member
Author
|
Results for
|
Contributor
|
Do we need to add v3? |
Member
Author
|
Changed |
KennethEnevoldsen
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3578