Skip to content

test: cache datasets check to avoid failing ci #2465

Closed
sam-hey wants to merge 1 commit intoembeddings-benchmark:mainfrom
sam-hey:cache/datasetloading_test
Closed

test: cache datasets check to avoid failing ci #2465
sam-hey wants to merge 1 commit intoembeddings-benchmark:mainfrom
sam-hey:cache/datasetloading_test

Conversation

@sam-hey
Copy link
Contributor

@sam-hey sam-hey commented Mar 31, 2025

Enhance the dataset availability test by caching the result when the dataset is available. The test should be skipped if it has already been performed by another CI on the same day.

Example:
https://github.com/embeddings-benchmark/mteb/actions/runs/14171665536/job/39696653523

Code Quality

  • Code Formatted: Format the code using make lint to maintain consistent style.

Testing

  • New Tests Added: Write tests to cover new functionality. Validate with make test-with-coverage.
  • Tests Passed: Run tests locally using make test or make test-with-coverage to ensure no existing functionality is broken.

Copy link
Member

@Samoed Samoed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want this, because we won't be able to check if some datasets were removed (like currently https://huggingface.co/datasets/navjordj/SNL_summarization)

@Samoed Samoed requested a review from isaac-chung March 31, 2025 13:17
@sam-hey
Copy link
Contributor Author

sam-hey commented Mar 31, 2025

It will check daily for any missing datasets, reducing the number of false positives caused by failed with 429 Client Error: Too Many Requests for URL. Additionally, newly added datasets will always be checked.

@sam-hey
Copy link
Contributor Author

sam-hey commented Mar 31, 2025

If you take a look here, almost all requests fail and need to be rerun:
image

@KennethEnevoldsen
Copy link
Contributor

Hmm, it seems like this PR has gotten stale - will close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants