test: cache datasets check to avoid failing ci #2465
Closed
sam-hey wants to merge 1 commit intoembeddings-benchmark:mainfrom
Closed
test: cache datasets check to avoid failing ci #2465sam-hey wants to merge 1 commit intoembeddings-benchmark:mainfrom
sam-hey wants to merge 1 commit intoembeddings-benchmark:mainfrom
Conversation
Samoed
reviewed
Mar 31, 2025
Member
Samoed
left a comment
There was a problem hiding this comment.
I don't think we want this, because we won't be able to check if some datasets were removed (like currently https://huggingface.co/datasets/navjordj/SNL_summarization)
Contributor
Author
|
It will check daily for any missing datasets, reducing the number of false positives caused by |
Contributor
Author
Contributor
|
Hmm, it seems like this PR has gotten stale - will close it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Enhance the dataset availability test by caching the result when the dataset is available. The test should be skipped if it has already been performed by another CI on the same day.
Example:
https://github.com/embeddings-benchmark/mteb/actions/runs/14171665536/job/39696653523
Code Quality
make lintto maintain consistent style.Testing
make test-with-coverage.make testormake test-with-coverageto ensure no existing functionality is broken.