Move triggering of lsp-ui-doc auto-hide to after display #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yyoncho @ericdallo Would you be able to review this fix? |
Lenbok
force-pushed
the
fix/lsp-ui-doc-auto-hide
branch
from
f8d997c to
08fe7df
Compare
|
(rebased to master) |
|
@yyoncho @jcs090218 Is someone able to review / merge this? |
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to address #695.
As well fixing auto-hide for docs explicitly invoked via
lsp-ui-doc-glance, this adds post-command clearing to bothlsp-ui-doc-show-with-mouseandlsp-ui-doc-show-with-cursor. That seems consistent to me, so I don't think it presents a problem.lsp-ui-doc-auto-hidesetting to disable auto-hiding for all three of these mechanisms?Fixes: #695