Skip to content

lsp-ui-doc-glance auto-hide is not triggering #695

@Lenbok

Description

@Lenbok

The documentation for this function says that the documentation will automatically hide on next typing, however this does not happen, in my experience.

Perhaps my reading of the code is wrong, but it seems the mechanism for clearing is unreliable, in that the clearing of the doc is triggered via post-command-hook but the retrieval of the documentation from the language server happens asynchronously (i.e. it's quite likely that the documentation is returned after lsp-ui-doc--glance-hide-frame has been removed from post-command-hook, which would lead to the documentation persisting).

I also put a message at the start of lsp-ui-doc--glance-hide-frame and it seems to be called immediately, rather than after the next command. Does adding a function to post-command-hook while a command is currently executing result in that function being called when the current command finishes executing? If so, this also seems like the wrong behaviour.

It seems that the addition of lsp-ui-doc--glance-hide-frame to post-command-hook should instead happen once the documentation is returned from the server.

Edit: the bug only affects inline doc display mode.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions