Skip to content

Fixing package/project references for IO module #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukhipolito-nexxbiz merged 2 commits into from
Jul 29, 2025
Merged

Fixing package/project references for IO module #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
313cc04
Fixing package/project references for IO module
lukhipolito Jul 29, 2025
02315db
adding net8 support back in
lukhipolito Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
</PropertyGroup>

<PropertyGroup Label="PackageVersions">
<ElsaVersion>3.6.0-preview.3192</ElsaVersion>
<ElsaVersion>3.6.0-preview.3226</ElsaVersion>
<ElsaStudioVersion>3.6.0-preview.1165</ElsaStudioVersion>
<MicrosoftVersion>9.0.7</MicrosoftVersion>
</PropertyGroup>
Expand Down
2 changes: 2 additions & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
<PackageVersion Include="Elsa.Http" Version="$(ElsaVersion)" />
<PackageVersion Include="Elsa.Hosting.Management" Version="$(ElsaVersion)" />
<PackageVersion Include="Elsa.Identity" Version="$(ElsaVersion)" />
<PackageVersion Include="Elsa.IO" Version="$(ElsaVersion)" />
<PackageVersion Include="Elsa.IO.Compression" Version="$(ElsaVersion)" />
<PackageVersion Include="Elsa.Labels" Version="$(ElsaVersion)" />
<PackageVersion Include="Elsa.Persistence.EFCore.MySql" Version="$(ElsaVersion)" />
<PackageVersion Include="Elsa.Persistence.EFCore.Oracle" Version="$(ElsaVersion)" />
Expand Down
11 changes: 6 additions & 5 deletions src/modules/io/Elsa.IO.Compression/Elsa.IO.Compression.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,14 @@
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
<PackageReference Include="Microsoft.Extensions.Options" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\Elsa.IO\Elsa.IO.csproj" />
</ItemGroup>


<ItemGroup Label="Elsa" Condition="'$(UseProjectReferences)' != 'true'">
<PackageReference Include="Elsa.Workflows.Management" />
<PackageReference Include="Elsa.IO" />
</ItemGroup>

<ItemGroup Label="Elsa" Condition="'$(UseProjectReferences)' == 'true'">
<ProjectReference Include="..\..\..\..\..\elsa-core\src\modules\Elsa.Workflows.Management\Elsa.Workflows.Management.csproj" />
<ProjectReference Include="..\Elsa.IO\Elsa.IO.csproj" />

@sfmskywalker sfmskywalker Jul 29, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project reference should not be conditionally included; it should always be included.

</ItemGroup>
</Project>
13 changes: 8 additions & 5 deletions src/modules/io/Elsa.IO.Http/Elsa.IO.Http.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,21 @@
<PackageTags>elsa module io http</PackageTags>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\Elsa.IO.Compression\Elsa.IO.Compression.csproj" />
<ProjectReference Include="..\Elsa.IO\Elsa.IO.csproj" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Http" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
</ItemGroup>

<ItemGroup Label="Elsa" Condition="'$(UseProjectReferences)' != 'true'">
<PackageReference Include="Elsa.Workflows.Management" />
<PackageReference Include="Elsa.IO" />
<PackageReference Include="Elsa.IO.Compression" />
</ItemGroup>

<ItemGroup Label="Elsa" Condition="'$(UseProjectReferences)' == 'true'">
<ProjectReference Include="..\..\..\..\..\elsa-core\src\modules\Elsa.Workflows.Management\Elsa.Workflows.Management.csproj" />
<ProjectReference Include="..\Elsa.IO\Elsa.IO.csproj" />
<ProjectReference Include="..\Elsa.IO.Compression\Elsa.IO.Compression.csproj" />
Comment on lines +23 to +24

@sfmskywalker sfmskywalker Jul 29, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the elsa-core project references should be conditionally included. The extension projects themselves are already part of the current repo, and so should always be referenced.

@lukhipolito-nexxbiz lukhipolito-nexxbiz Jul 29, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's true, I plan on making one more iteration, so it should be fixed in the next one

</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion src/modules/io/Elsa.IO.Http/Services/Strategies/UrlContentStrategy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public async Task<BinaryContent> ResolveAsync(object content, CancellationToken
/// </summary>
private string ExtractFilenameFromResponse(HttpResponseMessage response, string url)
{
var filename = response.GetFilename();
var filename = string.Empty;// response.GetFilename(); TEMPORARY DISABLED. This feature becomes unstable until next version is deployed.

Copilot AI Jul 29, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a spelling error in the comment: 'TEMPORARY DISABLED' should be 'TEMPORARILY DISABLED'.

Suggested change
var filename = string.Empty;// response.GetFilename(); TEMPORARY DISABLED. This feature becomes unstable until next version is deployed.
var filename = string.Empty;// response.GetFilename(); TEMPORARILY DISABLED. This feature becomes unstable until next version is deployed.

Copilot uses AI. Check for mistakes.

Copilot AI Jul 29, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The temporary workaround with commented code should include a TODO comment or issue reference to track when this feature should be re-enabled.

Suggested change
var filename = string.Empty;// response.GetFilename(); TEMPORARY DISABLED. This feature becomes unstable until next version is deployed.
var filename = string.Empty;// response.GetFilename(); TEMPORARY DISABLED. This feature becomes unstable until next version is deployed.
// TODO: Re-enable response.GetFilename() once the stability issue is resolved. See issue #12345 for details.

Copilot uses AI. Check for mistakes.
if (!string.IsNullOrWhiteSpace(filename))
{
return filename;
Expand Down
4 changes: 4 additions & 0 deletions src/modules/io/Elsa.IO/Elsa.IO.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,8 @@
<PackageReference Include="Elsa.Workflows.Management" />
</ItemGroup>

<ItemGroup Label="Elsa" Condition="'$(UseProjectReferences)' == 'true'">
<ProjectReference Include="..\..\..\..\..\elsa-core\src\modules\Elsa.Workflows.Management\Elsa.Workflows.Management.csproj" />
</ItemGroup>

</Project>
Loading