Skip to content

Fixing package/project references for IO module#75

Merged
lukhipolito-nexxbiz merged 2 commits intodevelop/3.6.0from
develop/update-io-version
Jul 29, 2025
Merged

Fixing package/project references for IO module#75
lukhipolito-nexxbiz merged 2 commits intodevelop/3.6.0from
develop/update-io-version

Conversation

@lukhipolito-nexxbiz
Copy link
Contributor

This pull request includes updates to package versions, adjustments to project references, and modifications to target frameworks. Additionally, a temporary change was made to disable an unstable feature in the UrlContentStrategy class. Below is a breakdown of the most important changes:

Package and Version Updates:

  • Updated the ElsaVersion from 3.6.0-preview.3192 to 3.6.0-preview.3226 in Directory.Build.props.
  • Added new package versions for Elsa.IO and Elsa.IO.Compression in Directory.Packages.props.

Project References and Dependencies:

  • Updated Elsa.IO.Compression.csproj to conditionally include Elsa.IO as a package reference or project reference based on the UseProjectReferences flag.
  • Updated Elsa.IO.Http.csproj to conditionally include Elsa.IO and Elsa.IO.Compression as package references or project references based on the UseProjectReferences flag.
  • Added a conditional project reference to Elsa.Workflows.Management in Elsa.IO.csproj.

Temporary Feature Adjustment:

  • Temporarily disabled the GetFilename method in UrlContentStrategy due to instability in the current version. The feature will be re-enabled in a future release.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes package and project references for the IO module by standardizing the conditional reference pattern and updating version numbers. The changes ensure consistent dependency management between package references and project references based on the UseProjectReferences flag.

  • Updated ElsaVersion from 3.6.0-preview.3192 to 3.6.0-preview.3226
  • Standardized conditional reference patterns across IO module projects
  • Temporarily disabled unstable filename extraction feature in UrlContentStrategy

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Directory.Build.props Updated ElsaVersion to newer preview build
Directory.Packages.props Added package version entries for Elsa.IO modules
Elsa.IO.csproj Added conditional project reference for Elsa.Workflows.Management
Elsa.IO.Compression.csproj Restructured to use conditional references pattern
Elsa.IO.Http.csproj Restructured to use conditional references pattern
UrlContentStrategy.cs Temporarily disabled GetFilename method call

private string ExtractFilenameFromResponse(HttpResponseMessage response, string url)
{
var filename = response.GetFilename();
var filename = string.Empty;// response.GetFilename(); TEMPORARY DISABLED. This feature becomes unstable until next version is deployed.
Copy link

Copilot AI Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a spelling error in the comment: 'TEMPORARY DISABLED' should be 'TEMPORARILY DISABLED'.

Suggested change
var filename = string.Empty;// response.GetFilename(); TEMPORARY DISABLED. This feature becomes unstable until next version is deployed.
var filename = string.Empty;// response.GetFilename(); TEMPORARILY DISABLED. This feature becomes unstable until next version is deployed.

Copilot uses AI. Check for mistakes.
private string ExtractFilenameFromResponse(HttpResponseMessage response, string url)
{
var filename = response.GetFilename();
var filename = string.Empty;// response.GetFilename(); TEMPORARY DISABLED. This feature becomes unstable until next version is deployed.
Copy link

Copilot AI Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The temporary workaround with commented code should include a TODO comment or issue reference to track when this feature should be re-enabled.

Suggested change
var filename = string.Empty;// response.GetFilename(); TEMPORARY DISABLED. This feature becomes unstable until next version is deployed.
var filename = string.Empty;// response.GetFilename(); TEMPORARY DISABLED. This feature becomes unstable until next version is deployed.
// TODO: Re-enable response.GetFilename() once the stability issue is resolved. See issue #12345 for details.

Copilot uses AI. Check for mistakes.
@lukhipolito-nexxbiz lukhipolito-nexxbiz merged commit bbf25fb into develop/3.6.0 Jul 29, 2025
6 checks passed
@lukhipolito lukhipolito deleted the develop/update-io-version branch July 29, 2025 12:23

<ItemGroup Label="Elsa" Condition="'$(UseProjectReferences)' == 'true'">
<ProjectReference Include="..\..\..\..\..\elsa-core\src\modules\Elsa.Workflows.Management\Elsa.Workflows.Management.csproj" />
<ProjectReference Include="..\Elsa.IO\Elsa.IO.csproj" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project reference should not be conditionally included; it should always be included.

Comment on lines +23 to +24
<ProjectReference Include="..\Elsa.IO\Elsa.IO.csproj" />
<ProjectReference Include="..\Elsa.IO.Compression\Elsa.IO.Compression.csproj" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the elsa-core project references should be conditionally included. The extension projects themselves are already part of the current repo, and so should always be referenced.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's true, I plan on making one more iteration, so it should be fixed in the next one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants