Fixing package/project references for IO module#75
Fixing package/project references for IO module#75lukhipolito-nexxbiz merged 2 commits intodevelop/3.6.0from
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes package and project references for the IO module by standardizing the conditional reference pattern and updating version numbers. The changes ensure consistent dependency management between package references and project references based on the UseProjectReferences flag.
- Updated ElsaVersion from
3.6.0-preview.3192to3.6.0-preview.3226 - Standardized conditional reference patterns across IO module projects
- Temporarily disabled unstable filename extraction feature in UrlContentStrategy
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.props | Updated ElsaVersion to newer preview build |
| Directory.Packages.props | Added package version entries for Elsa.IO modules |
| Elsa.IO.csproj | Added conditional project reference for Elsa.Workflows.Management |
| Elsa.IO.Compression.csproj | Restructured to use conditional references pattern |
| Elsa.IO.Http.csproj | Restructured to use conditional references pattern |
| UrlContentStrategy.cs | Temporarily disabled GetFilename method call |
| private string ExtractFilenameFromResponse(HttpResponseMessage response, string url) | ||
| { | ||
| var filename = response.GetFilename(); | ||
| var filename = string.Empty;// response.GetFilename(); TEMPORARY DISABLED. This feature becomes unstable until next version is deployed. |
There was a problem hiding this comment.
There's a spelling error in the comment: 'TEMPORARY DISABLED' should be 'TEMPORARILY DISABLED'.
| var filename = string.Empty;// response.GetFilename(); TEMPORARY DISABLED. This feature becomes unstable until next version is deployed. | |
| var filename = string.Empty;// response.GetFilename(); TEMPORARILY DISABLED. This feature becomes unstable until next version is deployed. |
| private string ExtractFilenameFromResponse(HttpResponseMessage response, string url) | ||
| { | ||
| var filename = response.GetFilename(); | ||
| var filename = string.Empty;// response.GetFilename(); TEMPORARY DISABLED. This feature becomes unstable until next version is deployed. |
There was a problem hiding this comment.
The temporary workaround with commented code should include a TODO comment or issue reference to track when this feature should be re-enabled.
| var filename = string.Empty;// response.GetFilename(); TEMPORARY DISABLED. This feature becomes unstable until next version is deployed. | |
| var filename = string.Empty;// response.GetFilename(); TEMPORARY DISABLED. This feature becomes unstable until next version is deployed. | |
| // TODO: Re-enable response.GetFilename() once the stability issue is resolved. See issue #12345 for details. |
|
|
||
| <ItemGroup Label="Elsa" Condition="'$(UseProjectReferences)' == 'true'"> | ||
| <ProjectReference Include="..\..\..\..\..\elsa-core\src\modules\Elsa.Workflows.Management\Elsa.Workflows.Management.csproj" /> | ||
| <ProjectReference Include="..\Elsa.IO\Elsa.IO.csproj" /> |
There was a problem hiding this comment.
This project reference should not be conditionally included; it should always be included.
| <ProjectReference Include="..\Elsa.IO\Elsa.IO.csproj" /> | ||
| <ProjectReference Include="..\Elsa.IO.Compression\Elsa.IO.Compression.csproj" /> |
There was a problem hiding this comment.
Only the elsa-core project references should be conditionally included. The extension projects themselves are already part of the current repo, and so should always be referenced.
There was a problem hiding this comment.
that's true, I plan on making one more iteration, so it should be fixed in the next one
This pull request includes updates to package versions, adjustments to project references, and modifications to target frameworks. Additionally, a temporary change was made to disable an unstable feature in the
UrlContentStrategyclass. Below is a breakdown of the most important changes:Package and Version Updates:
ElsaVersionfrom3.6.0-preview.3192to3.6.0-preview.3226inDirectory.Build.props.Elsa.IOandElsa.IO.CompressioninDirectory.Packages.props.Project References and Dependencies:
Elsa.IO.Compression.csprojto conditionally includeElsa.IOas a package reference or project reference based on theUseProjectReferencesflag.Elsa.IO.Http.csprojto conditionally includeElsa.IOandElsa.IO.Compressionas package references or project references based on theUseProjectReferencesflag.Elsa.Workflows.ManagementinElsa.IO.csproj.Temporary Feature Adjustment:
GetFilenamemethod inUrlContentStrategydue to instability in the current version. The feature will be re-enabled in a future release.