Skip to content

Refactor inbound connection handling to schedule outbound activity before canceling remaining activities #7340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfmskywalker merged 2 commits into from
Mar 2, 2026
Merged

Refactor inbound connection handling to schedule outbound activity before canceling remaining activities #7340

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82c69d0
Refactor inbound connection handling to schedule outbound activity be…
sfmskywalker Mar 2, 2026
34d6694
Add regression test for WaitAny join schedule-before-cancel ordering …
Copilot Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/modules/Elsa.Workflows.Core/Activities/Flowchart/Activities/Flowchart.Counters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,11 +313,12 @@ private static async ValueTask<bool> MaybeScheduleWaitAnyActivityAsync(FlowGraph

if (flowScope.AnyInboundConnectionsFollowed(flowGraph, outboundActivity))
{
// This is the first inbound connection followed; schedule the outbound activity
var scheduleResponse = await ScheduleOutboundActivityAsync(flowchartContext, outboundActivity, completionCallback);
// An inbound connection has been followed; cancel remaining inbound activities
await CancelRemainingInboundActivitiesAsync(flowchartContext, outboundActivity);

// This is the first inbound connection followed; schedule the outbound activity
return await ScheduleOutboundActivityAsync(flowchartContext, outboundActivity, completionCallback);
return scheduleResponse;
Comment thread
sfmskywalker marked this conversation as resolved.
}

if (flowScope.AllInboundConnectionsVisited(flowGraph, outboundActivity))
Expand Down
Loading