Refactor inbound connection handling to schedule outbound activity before canceling remaining activities

[sfmskywalker]

No description provided.

[greptile-apps]

Greptile Summary

This PR refactors the FlowJoinMode.WaitAny handling in the flowchart counter-based logic to schedule the outbound activity before canceling remaining inbound activities.

• Changed the order of operations in MaybeScheduleWaitAnyActivityAsync method (lines 316-321)
• Now schedules the outbound activity first, then cancels remaining inbound activities
• Updated inline comments to reflect the new execution order
• This defensive refactoring ensures the continuation is queued in the scheduler before any cleanup or side effects from cancellation occur

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The change is a small, well-contained refactoring that reorders two async operations. Scheduling the outbound activity before canceling inbound activities is a defensive improvement that prevents potential race conditions. The logic is straightforward, comments were updated appropriately, and the return value handling is correct.
• No files require special attention

Important Files Changed

Filename	Overview
src/modules/Elsa.Workflows.Core/Activities/Flowchart/Activities/Flowchart.Counters.cs	Reordered operations in WaitAny join handling to schedule outbound activity before canceling remaining inbound activities, improving execution safety

_{Last reviewed commit: 82c69d0}

[Copilot]

Pull request overview

Refactors counter-based flowchart inbound connection handling for FlowJoinMode.WaitAny to ensure the outbound activity is scheduled before canceling remaining inbound/ancestor activities, preventing premature completion paths during cancellation.

Changes:

• Reorders WaitAny handling to schedule the outbound activity first, then cancel remaining inbound activities.
• Captures the schedule result in a local variable and returns it after cancellations complete.

[Copilot]

@sfmskywalker I've opened a new pull request, #7341, to work on those changes. Once the pull request is ready, I'll request review from you.