fix(cloud): remove duplicate runWithTrajectoryPurpose Worker-stub export — unblock prod deploy - #11865
Merged
Conversation
…ort — unblock prod deploy The develop→main promote (#11861) carried TWO runWithTrajectoryPurpose exports in src/stubs/elizaos-core.ts: my #11847 fix + codex's parallel #11857 fix both landed on develop. The duplicate makes the Worker esbuild fail with 'redeclares runWithTrajectoryPurpose' at the Deploy API Worker step — so the prod deploy (run 28653353358) fails, blocking the money fixes from going live. Removed the second (my) copy, kept the top-of-file one. Verified: wrangler --dry-run builds clean. Fixes the same issue #11857 fixes on develop.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
NubsCarson
added a commit
that referenced
this pull request
Jul 3, 2026
…fuse the next promote deleting BOTH copies (#11875) #11845/#11847 raced the same missing-export fix into two spots, duplicating the export. The dedup then ALSO raced: develop's #11857 deleted the first copy while main's #11865 hotfix deleted the second. Relative to the promote merge-base both sides now carry a different single deletion, so the next develop->main promote auto-merges BOTH deletions cleanly and ships a stub with ZERO runWithTrajectoryPurpose exports — re-breaking every Worker deploy with the original "No matching export" build failure (verified by simulating the merge: surviving export count = 0). Fix: make develop's file byte-identical to main's (keep the first copy). Identical content on both sides makes the promote merge trivially correct. `bun run --cwd packages/cloud/api typecheck` passes with this tree. Co-authored-by: NubsCarson <carson@nubs.site>
NubsCarson
added a commit
that referenced
this pull request
Jul 3, 2026
… break (#11902) After the #11861 promote, the runWithTrajectoryPurpose Worker stub was deduped DIFFERENTLY on each branch: #11865 removed the second copy on main (kept the top 'pass-through' one); #11857 removed the top copy on develop (kept the other). A develop->main 3-way merge would then apply BOTH removals and drop runWithTrajectoryPurpose entirely (verified: merge-tree yields 0 exports) — silently re-breaking the Worker build on the next promote. Fix: make develop's stub byte-identical to main's (single 'pass-through' export, matching what's already deployed on prod). Future promotes are now a no-op on this file. Functionally identical no-op stub either way.
This was referenced Jul 3, 2026
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prod-deploy hotfix. The #11861 promote carried TWO
runWithTrajectoryPurposeexports incloud/api/src/stubs/elizaos-core.ts(my #11847 + codex's parallel #11857 both landed on develop). The duplicate fails the Worker esbuild ('redeclares runWithTrajectoryPurpose') at Deploy API Worker → the prod deploy (28653353358) fails, blocking the money fixes going live. Removed the second copy;wrangler --dry-runbuilds clean (15.8 MB, single export). Same fix #11857 applies to develop. —[cloud-frontdoor]