[codex] fix cloud api core stub duplicate export - #11857
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1a60f94 to
39a773a
Compare
|
Validated the rebased develop fix locally in /tmp/eliza-11857-pr. Checks run:
This directly addresses the Cloud CF Deploy Verify Worker failure: duplicate exported variable |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
NubsCarson
left a comment
NubsCarson
left a comment
There was a problem hiding this comment.
Verified locally against develop tip (c5e1ca5):
bun run --cwd packages/cloud/api typecheckon develop fails:src/stubs/elizaos-core.ts(29,17) + (283,17) TS2323/TS2393— #11845 and #11847 raced the same missing-export fix into two spots.- With this PR's deletion applied, the same typecheck passes clean.
- The deploy workflow's
Verify Workerstep runs exactly that command, so the in-flight prod deploy on main (run 28653353358, promote #11861) and the develop staging deploy (run 28653155120) will both fail at Verify Worker without this.
Admin-merging as a deploy-unblock (CI queue is saturated; change is a 15-line duplicate deletion, verified locally), then promoting to main so prod can ship.
— nubs-cloud [cloud-frontdoor]
…fuse the next promote deleting BOTH copies (#11875) #11845/#11847 raced the same missing-export fix into two spots, duplicating the export. The dedup then ALSO raced: develop's #11857 deleted the first copy while main's #11865 hotfix deleted the second. Relative to the promote merge-base both sides now carry a different single deletion, so the next develop->main promote auto-merges BOTH deletions cleanly and ships a stub with ZERO runWithTrajectoryPurpose exports — re-breaking every Worker deploy with the original "No matching export" build failure (verified by simulating the merge: surviving export count = 0). Fix: make develop's file byte-identical to main's (keep the first copy). Identical content on both sides makes the promote merge trivially correct. `bun run --cwd packages/cloud/api typecheck` passes with this tree. Co-authored-by: NubsCarson <carson@nubs.site>
… break (#11902) After the #11861 promote, the runWithTrajectoryPurpose Worker stub was deduped DIFFERENTLY on each branch: #11865 removed the second copy on main (kept the top 'pass-through' one); #11857 removed the top copy on develop (kept the other). A develop->main 3-way merge would then apply BOTH removals and drop runWithTrajectoryPurpose entirely (verified: merge-tree yields 0 exports) — silently re-breaking the Worker build on the next promote. Fix: make develop's stub byte-identical to main's (single 'pass-through' export, matching what's already deployed on prod). Future promotes are now a no-op on this file. Functionally identical no-op stub either way.
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
❌ PR title does not match the required pattern. Please use one of these formats:
|
3 participants
Summary
Removes the duplicate
runWithTrajectoryPurposeexport from the Cloudflare@elizaos/corecompatibility stub. The latest develop Cloud CF Deploy failure is in the Verify Worker step:src/stubs/elizaos-core.tsredeclaresrunWithTrajectoryPurposeat lines 29 and 283.The later grouped trajectory stub remains in place, so the worker bundle still has the export needed by
@elizaos/sharedemail classification.Verification
bun --check packages/cloud/api/src/stubs/elizaos-core.tsbunx @biomejs/biome@2.5.2 check packages/cloud/api/src/stubs/elizaos-core.tsgit diff --checkNotes
A full
bun install --frozen-lockfile --ignore-scriptswas attempted in a sparse checkout first, but Bun requires all workspace paths to be present and failed on omitted workspaces. Expanding to a full checkout was abandoned after the Git materialization stalled locally; disk was tight at roughly 34-35 GiB free.