fix(ui): green all 6 red quality gates on develop (#11036) - #11052
Merged
Merged
Conversation
Six quality-gate tests were red on develop, protecting nothing while every
branch inherited the noise. Each fixed with an evidence-based intent decision:
1-3. no-focus-ring-gate — the design system owns focus affordances globally:
- MessageSearchPanel: drop focus:bg-muted/60 + focus:outline-none (hover keeps
the pointer affordance).
- agent-orchestrator-room-view: the status-dot cutout ring-1 ring-bg becomes
border border-bg (same 1px bg-colored cutout, no ring utility).
- ContinuousChatOverlay edit-textarea (#10713, my surface): drop
focus:border-white/40; the base border-white/20 stays.
4. will-change-gate — xr-scene declared willChange on LAYOUT properties
(left/top/width/height), the exact anti-pattern the gate's doctrine calls
out (only transform/opacity benefit from compositor promotion; layout props
still reflow). Removed the ineffective hint.
5. view-lifecycle-matrix — the MATRIX carried stale rows: companion (feature
removed by #10434) and voice are no longer in BUILTIN_VIEW_IDS. Removed the
stale classifications; the per-view policy loop (74 cases) stays green.
6. widget-coverage — ratcheted the app-manifest floor 28 → 26 with receipts:
plugin-companion removed by #10434, plugin-elizamaker by c394453 — both
intentional deletions that shrank the set without the floor moving.
7. overlay-app-registry ×2 — the expected arrays listed feed before contacts
while the assertion sorts the received list; the 4-member set is identical,
only the expectation ordering was wrong. Alphabetized.
All 5 gate files green (93 tests); packages/ui typecheck exit 0; touched-
component suites (ContinuousChatOverlay + message-search, 109 tests) green.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #11036 — six quality-gate tests were red on develop (verified at tip), so the gates protected nothing and every branch inherited the noise in
bun run --cwd packages/ui test. Each fixed with an evidence-based intent decision, not a blind expectation bump:no-focus-ring— MessageSearchPanelfocus:bg-muted/60 focus:outline-none— the design system owns focus affordances; hover keeps the pointer affordance.no-focus-ring— orchestrator room viewring-1 ring-bg→border border-bg(identical 1px bg-colored cutout, no bannedring-*utility).no-focus-ring— ContinuousChatOverlay edit-textareafocus:border-white/40; baseborder-white/20stays. Sanctioned answer to the issue's "is it sanctioned?" question: no.will-change— xr-scenewillChange: "left, top, width, height"— layout properties, the exact anti-pattern the gate's doctrine documents (only transform/opacity benefit; layout props reflow regardless). Removed the ineffective hint.view-lifecycle-matrixcompanion(feature removed by #10434) andvoiceare gone fromBUILTIN_VIEW_IDS. Removed the stale classifications; the 74 per-view policy cases stay green.widget-coverageplugin-companionremoved by #10434,plugin-elizamakerbyc3944534b0— both intentional deletions (verified on a full 157-dir checkout, correcting my own earlier partial-checkout assumption on #10803).overlay-app-registry×2feedbeforecontactsvs the sorted received). Alphabetized.Verification
Android/visual: the three visual changes are affordance-neutral (hover preserved; cutout identical; base border unchanged) — no page-level visual delta. Real-LLM: N/A.
🤖 Generated with Claude Code