feat(ui/widgets): remove the redundant Messages home widget (#10697) - #10803
Conversation
The standalone Messages home tile re-fetched and re-listed recent conversations
that the always-present chat overlay already covers — a second inbox on the home
grid. Remove it; follow-up-worthy messages now surface as `category: "message"`
notifications in the notification rail (the canonical "important message to
follow up" signal).
- Delete `MessagesWidget` + its stories/tests.
- Unregister from the widget registry: drop the import, the
`registerWidgetComponent("messages", …)`, the `messages.recent` home-slot
declaration, and `"messages"` from the always-visible core set.
- The `@elizaos/plugin-messages` app plugin now folds into the notification rail
via a `defaultWidget: "notifications"` sink declaration (same pattern as the
phone plugin), so the per-plugin home-widget coverage gate stays green; repoint
the phone plugin's `defaultWidget` off `"messages"` too, and alias the
`messages` sink → notifications.
- Reconcile the home/coverage tests + WIDGET_MATRIX (drop the `messages.recent`
row); the native-OS Messages *view/tab* (SMS app) is a separate surface and is
untouched.
Non-breaking: the `messages` member of the core `defaultWidget` union is kept
(aliased to notifications); dropping it from the `@elizaos/core` plugin contract
is a separate follow-up.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
❌ PR title does not match the required pattern. Please use one of these formats:
|
1 participant
What & why
The #1 proposed change of #10697: remove the standalone Messages home tile. It re-fetched and re-listed recent conversations that the always-present chat overlay (
ContinuousChatOverlay) already covers — a second inbox on the home grid. The user wants the home grid to surface actionable attention, not a duplicate conversation list. Follow-up-worthy messages already flow through the notification model ascategory: "message"(mentions →priority: "high"), so they surface in the notification rail instead.Change
MessagesWidget+messages.stories.tsx+messages.test.tsx+messages.populated.test.tsx.widgets/registry.ts: drop the import, theregisterWidgetComponent("messages", …), themessages.recenthome-slot declaration, and"messages"from the always-visible core set.@elizaos/plugin-messagescovered: the app plugin now folds into the notification rail via adefaultWidget: "notifications"sink declaration (same pattern as thephoneplugin), so the per-plugin home-widget coverage gate (widget-coverage.test.ts) stays green. The phone plugin'sdefaultWidgetis repointed off"messages"too, and themessagessink aliases to notifications.registry.home.test.ts(now asserts nomessages.recentresolves),WidgetHost.home-launch.test.tsx(drops thewidget-messagesassertions),WIDGET_MATRIX.md(drops the row), and the e2e fixture comment.The native-OS Messages view/tab (the SMS app in
NATIVE_OS_TILES/useAvailableViews/ launcher curation) is a separate surface and is deliberately untouched — verified those tests stay green.Non-breaking
The
messagesmember of the coredefaultWidgetunion (@elizaos/coreplugin.ts) is kept (aliased to notifications), so no@elizaos/coreplugin-contract change and no external-plugin break. Dropping the union member is a separable follow-up.Tests
Evidence
On-device (Android 14 emulator) — the home grid before (duplicate Messages tile + Notifications) → after (Messages tile removed; the message folds into the Notifications rail) —
.github/issue-evidence/10697-remove-messages-widget-android.png:Real-LLM trajectory: N/A — widget-registry consolidation, no model/prompt path.
🤖 Generated with Claude Code