Add support for opening single files #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make it possible to start default client for single file
…itled file this leads to broken behavior of 2 servers running with the same rootUri
When starting a default client even if we do not pass a workspace folder to client options vs code will fall back to first workspace folder if any is open. This means that we cannot use default client for that case as it will result in 2 servers started for the same rootUri. We need to pass a permissive document filter that will match untitled files to the first workspace client. Otherwise language server features won't work for such files. We cannot pass them to all clients as in that case in multiworkspace cases all servers would be handling the same messages. On the other hand if no folder is open we have to use default client.
6 tasks
axelson
requested changes
Jun 30, 2021
|
@axelson I think I addressed all of the comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there was some support at some point but it got broken (probably when workspace folders concept was introduced). This PR brings it back and fixes some issues and inconsistencies around untitled files.
Addresses elixir-lsp/elixir-ls#307, depends on elixir-lsp/elixir-ls#562